Commit graph

682 commits

Author SHA1 Message Date
Unknown W. Brackets
0532b35538 Osk: Update by button flag consistently. 2023-02-12 10:06:53 -08:00
Unknown W. Brackets
d7732f7fd7 Dialog: Warn when ignoring the dialog language. 2023-02-08 19:04:18 -08:00
Unknown W. Brackets
fcc1abc7c3 Dialog: Update by button flag consistently.
Always check for the flag to change in Update().
2023-02-08 19:02:37 -08:00
Unknown W. Brackets
dea9cac16c Core: Add range checks to some helpers and similar. 2023-01-09 16:56:18 -08:00
Henrik Rydgård
7e374c9324 Address feedback, more fixes 2023-01-05 08:38:53 +01:00
Henrik Rydgård
fd7cc76d95 Remove unnecessary savedata version reporting 2023-01-02 23:22:54 +01:00
Unknown W. Brackets
87172f9dd5 Dialog: Fix confirm/cancel button reversal. 2023-01-01 09:34:13 -08:00
Henrik Rydgård
61cc6cd0e0 Fix bug swapping O/X visually on PSPOskDialog 2022-12-16 21:51:20 +01:00
Unknown W. Brackets
a7b7bf7826 Global: Set many read-only params as const.
This makes what they do and which args to use clearer, if nothing else.
2022-12-10 21:13:36 -08:00
Unknown W. Brackets
f44852bb18 Global: Cleanup virtual/override specifiers.
Also missing virtual destructors, hidden non-overrides, etc.
2022-12-10 21:13:36 -08:00
Henrik Rydgård
93e5060137 Load and cache langValuesMapping on demand 2022-12-05 12:10:45 +01:00
Henrik Rydgård
f954013d0b Fix (?) the savestate bug in PSPSaveDialog/SaveDataParam
PSPSaveDialog::DoState called SetPspParam in non-READ modes, which could
modify it.
2022-12-02 22:46:39 +01:00
Henrik Rydgård
f5a7661c51 Add a NOOP state to reduce logspam after error 2022-12-02 22:46:38 +01:00
Henrik Rydgård
5b3a993db7 Typo fix 2022-11-28 09:50:23 +01:00
Henrik Rydgård
21647cd3c1 Blind workaround for Shining Ark circle button problem
Seems the game might not handle the case of confirm button being set to
cross properly, so force it to circle if this game is running.

Fixes #15663 (hopefully..)
2022-11-27 23:32:43 +01:00
Unknown W. Brackets
29e7a53b5d Savedata: Update filelist on file erasure.
Also stop reporting as "not coded."
2022-10-16 09:20:04 -07:00
Unknown W. Brackets
db5011d7f1 Savedata: Cache SFO data during processing.
This only caches between touching PSP code, in case something changes.
Reduces cases of multiple SFO lookups and reads.
2022-10-09 14:42:31 -07:00
Unknown W. Brackets
5bed35b293 Savedata: Skip and defer texture exist check.
We can skip if there's no UI.
2022-10-09 14:42:31 -07:00
Unknown W. Brackets
8c1acc30e4 Savedata: Combine file info and dir listing calls. 2022-10-09 14:42:31 -07:00
Unknown W. Brackets
6168e03b4a Savedata: Reduce some duplicate file info lookups. 2022-10-09 14:42:31 -07:00
Unknown W. Brackets
d473aa6db0 Module: Cleanup file read pattern.
Let's always use ReadEntireFile() when we can.
2022-10-09 14:42:30 -07:00
lainon
b304551747 Code readability, vec reserve() and remove excess c_str() 2022-09-30 12:31:32 +03:00
lainon
fec708489a Correct cleaning string and remove unused vars 2022-09-30 12:26:30 +03:00
Unknown W. Brackets
f0afc97247 Gamedata: Cleanup install request args/validate. 2022-09-18 20:39:13 -07:00
Unknown W. Brackets
ce80900b75 Savedata: Return errors more correctly on load.
If the buffer isn't large enough, return an error.  See #14687, thanks
sum2012 and gid15.
For many error cases, ensure SFO data and bind are not updated on failure,
and that dataSize is forced to zero on data errors.
2022-09-13 00:10:27 -07:00
Unknown W. Brackets
dd0de46ed9 Io: Use PSPPointer instead of struct temps. 2022-09-03 10:44:11 -07:00
Henrik Rydgård
c9048c3748 Shrink the DeferredDrawcall struct, because why not. Assorted cleanup 2022-09-01 11:59:33 +02:00
Henrik Rydgård
70b9dcc9a3 Initialize a bunch of Dialog structs 2022-08-18 16:46:22 +02:00
Unknown W. Brackets
71d66ae1ec Dialog: Add missing header for MSVC 2017. 2022-08-06 21:13:39 -07:00
ANR2ME
4c9e1dec1a Fix include issue. 2022-08-04 16:35:30 +07:00
ANR2ME
dcf3ece8f4 Implement NP Signin Dialog (faked signin) 2022-08-04 16:12:25 +07:00
Unknown W. Brackets
3ccbb51e43 Osk: Allow upper/lower for all keyboards.
In previous tests, this seemed to be limited, but now I can't reproduce.
Instead, let's just use it as the hint for the default case.
See #15010.
2022-07-16 17:47:31 -07:00
Henrik Rydgård
c69dd2f2e4
Merge pull request #15562 from unknownbrackets/securemode
Savedata: Allow no key when not using SECURE modes
2022-05-29 23:01:43 +02:00
Unknown W. Brackets
b9310f1473 Savedata: Allow no key when not using SECURE modes.
For example, MAKEDATA with no key but explicit secureVersion is fine and
does create data.  However, it should still mark the version in
SAVEDATA_PARAMS, which currently we're failing to do.  Load then does some
form of validation of this version (but it's not an exact check weirdly.)

See #15068.
2022-05-29 13:23:16 -07:00
Unknown W. Brackets
df4017baba Osk: Fix fullscreen check.
See previous 21bf41e, failed to add this change because of UTF-16.
2022-05-29 11:20:41 -07:00
Unknown W. Brackets
ffbd9bbe98 Global: Fix some int/size_t conversion warnings. 2022-03-13 12:03:48 -07:00
Unknown W. Brackets
2479d52202 Global: Reduce includes of common headers.
In many places, string, map, or Common.h were included but not needed.
2022-01-30 16:35:33 -08:00
Unknown W. Brackets
48b597a1b9 Display: Move core counters/stats to HW file.
This separates things better, so not everything is pulling in HLE.
2022-01-30 11:53:48 -08:00
Unknown W. Brackets
e75d2a097b Savedata: Fix indeterminate timing of field update.
This makes the test pass consistently, instead of depending on thread
timing.
2022-01-26 00:31:30 -08:00
Unknown W. Brackets
8e15f755e6 UI: Add a sysprop for if the device has a keyboard.
Still left some ifdefs because of System_InputBoxGetString(), but
hopefully we can move away from them.  Some devices (like SDL) may only
optionally have a keyboard, so it's a runtime check.
2021-10-19 10:01:52 -07:00
Unknown W. Brackets
29aa81be9e Savedata: Respect IO timing method setting. 2021-09-12 07:05:51 -07:00
Henrik Rydgård
de3d711616 Move FixPathCase to Common/File/Path 2021-09-11 21:17:23 +02:00
Henrik Rydgård
b05a74803d Remove another redundant check, comment fixes 2021-09-11 20:31:42 +02:00
Henrik Rydgård
71056e3486 SFO return value fix, oops 2021-09-11 20:26:36 +02:00
Henrik Rydgård
36079b86d0 Optimize away a couple of existence checks 2021-09-11 19:53:19 +02:00
Henrik Rydgård
5d53e59c1d Optimize ReadPSPFile (which should probably be replaced with ReadEntireFile anyway) 2021-09-11 19:33:28 +02:00
Henrik Rydgård
8e2b73b05f Optimize MetaFileSystem::ReadEntireFile 2021-09-11 19:32:37 +02:00
Unknown W. Brackets
a5fce6d0b2 Savedata: Use PARAM.SFO constant properly. 2021-08-23 23:01:02 -07:00
Unknown W. Brackets
f530be0969 Dialog: Prevent reschedule on shutdown start.
This is a bit strange, but tests seem to suggest this is correct.
A worse priority thread won't run before savedata shutdown hits 0, but the
thread that initiated shutdown runs before shutdown completes.

Fixes Freakout Extreme Freeride loading savedata.
2021-08-14 20:15:34 -07:00
Unknown W. Brackets
aecb138f90 Dialog: Avoid crash with hacked dialog start.
See #14727.  If a dialog shutdown is in progress and we incorrectly allow
a startup at that time, it breaks other things.  This tries to at least
work around that.
2021-08-14 07:46:38 -07:00