SDL_InitSubSystem() takes approximately 0.6s for me, presumably because
it does lots of device enumeration.
When all Input-sdl-ControlX configuration sections are present and
valid, then input-sdl calls SDL_InitSubSystem(SDL_INIT_JOYSTICK) three
times. When configuration is not present, this happens once more for
each connected joysick.
Moving the SDL_InitSubSystem(SDL_INIT_JOYSTICK) calls to a higher level
allows for a reduction to two total calls (whether configuration is
present or not). The first remaining call happens when loading the
plugin and the second call happens when attaching the plugin to the
core. Keeping these calls separate allows SDL to refresh itself in case
the user has plugged/unplugged a joystick in between (not likely with
ui-console, but perhaps with a GUI).
On a system with three joystick devices, loading a game and then
exiting (--testshots 0), this reduces time by:
with configuration: 11.5%
without configuration: 32.1%
Full benchmarks:
[ ----------- original behavior -------------]
[ with configuraton ][ without configuration ]
real 0m5.255s real 0m7.470s
user 0m1.499s user 0m1.534s
sys 0m0.110s sys 0m0.135s
real 0m5.313s real 0m7.471s
user 0m1.471s user 0m1.514s
sys 0m0.119s sys 0m0.120s
real 0m5.360s real 0m7.414s
user 0m1.496s user 0m1.569s
sys 0m0.106s sys 0m0.127s
[ ------------ patched behavior -------------]
[ with configuraton ][ without configuration ]
real 0m4.741s real 0m5.088s
user 0m1.473s user 0m1.468s
sys 0m0.122s sys 0m0.101s
real 0m4.724s real 0m5.066s
user 0m1.511s user 0m1.484s
sys 0m0.082s sys 0m0.090s
real 0m4.628s real 0m5.024s
user 0m1.494s user 0m1.504s
sys 0m0.094s sys 0m0.081s
Known front-ends have been modified to save configuration after plugin
initialization but before running the game. Now it is no longer
necessary for individual plugins to save their config.
Removing calls to ConfigSaveSection from within plugins makes the
mupen64plus-ui-console '--nosaveoptions' parameter work.
Also remove unused reference to ConfigSaveFile.
Legit DS4 controllers advertise themselves as Wireless Controller when connected via Bluetooth.
sony 0005:054C:05C4.0043: input,hidraw4: BLUETOOTH HID v81.00 Gamepad [Wireless Controller] on b0:25:9f:d3:8b:d8
