Commit graph

10 commits

Author SHA1 Message Date
Marc Jones
70b7967bb6 Fix rs690 bug about GPPSB configuration.
Signed-off-by:  Maggie Li <maggie.li@amd.com>
Reviewed-by:    Zheng Bao <Zheng.bao@amd.com>
Acked-by: Marc Jones <marcj303@gmail.com>

git-svn-id: svn://coreboot.org/repository/coreboot-v3@1123 f3766cd6-281f-0410-b1cd-43a5c92072e9
2009-01-23 22:18:24 +00:00
Myles Watson
72c2e85313 This patch changes all occurrences of pci_dev_set_resources ->
pci_set_resources.  There is no matching pci_bus_set_resources, so it's
confusing to see the dev function in the bus structures.
 
Signed-off-by: Myles Watson <mylesgw@gmail.com>

Acked-by: Peter Stuge <peter@stuge.se>

git-svn-id: svn://coreboot.org/repository/coreboot-v3@1048 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-11-24 14:06:10 +00:00
Marc Jones
ea883f4ad2 Whitespace cleanup on AMD southbridge device_operations structs. (trivial)
Signed-off-by: Marc Jones <marc.jones@amd.com>
Acked-by: Marc Jones <marc.jones@amd.com>

git-svn-id: svn://coreboot.org/repository/coreboot-v3@955 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-27 23:16:17 +00:00
Ronald G. Minnich
cedf16ca69 Marc reviewed the v3 device tree code and we developed the set of
cleanups/fixes.

Fixup device tree code. Add/change methods as needed. 
This should help serengeti.
Signed-off-by: Ronald G. Minnich<rminnich@gmail.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Corey Osgood <corey.osgood@gmail.com>
Acked-by: Marc Jones <marc.jones@amd.com>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@954 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-27 20:05:38 +00:00
Ronald G. Minnich
6dc3ebfb5c Having received no comments on this pro or con, and knowing we have to
have this code, I'm comitting it.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@934 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-16 16:02:12 +00:00
Uwe Hermann
5cd018b2ca Move AMD RS690 and SB600 PCI IDs to pci_ids.h where they should be.
Build-tested with the AMD dbm690t board.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Marc Jones <marc.jones@amd.com>



git-svn-id: svn://coreboot.org/repository/coreboot-v3@922 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-13 21:41:03 +00:00
Carl-Daniel Hailfinger
e3abcbefc2 Replace magic numbers with existing symbolic constants. SB600 is heavily
affected. This mostly targets pci_*_config*() calls.

This is part of my quest to make existing code more readable without
looking up the meaning of magic numbers.

Ron pointed out that this enables better kscope usage.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@913 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-09 22:19:53 +00:00
Ronald G. Minnich
e3517187a0 Fix the sb600 and rs690 code in the same way we just fixed the amd8111.
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@911 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-09 15:11:52 +00:00
Ronald G. Minnich
b1dfc9858a This sb600 and rs690 support for a dbm690t that compiles. Stage0 is
23K, too large.    

dbe62 was tested and works i.e. this does no harm.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>



git-svn-id: svn://coreboot.org/repository/coreboot-v3@893 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-06 17:12:38 +00:00
Ronald G. Minnich
cadd0126aa First cut at moving from v2 to v3.
There are some interesting issues here. The enables for the various 
devices are a global bitmask: 
Define port_enable, (bit map): GFX(2,3), GPP(4,5,6,7)

But v3 would allow us to not have the bit mask. OTOH, we would end up 
with 3 .dts files for the pcie ports for this enable; good or bad? 
GOOD --> highly custom configuration possible for each port
BAD --> 3 .dts files

Part of the issue is that the link from the dts to the device operations 
structure is done as follows: 
struct device_operations sb600_usb2 = {
	.id = {.type = DEVICE_ID_PCI,
		{.pci = {.vendor = PCI_VENDOR_ID_ATI,
			      .device = PCI_DEVICE_ID_ATI_SB600_USB2}}},

And this structure is named in the .dts for that device_operations:
{
	device_operations = "sb600_usb2";
};

requiring a different dts node for each set of device_operations. 

The device tree compiler generates the code to create these connections 
and puts that code into the the static_tree.c file. 

Having a .dts file for each port gives us a lot of flexibility; but is 
it too inconvenient? This is an unresolved problem; unhandled at present 
for the *6* USB ports for the sb600. 

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>



git-svn-id: svn://coreboot.org/repository/coreboot-v3@886 f3766cd6-281f-0410-b1cd-43a5c92072e9
2008-10-03 15:47:10 +00:00