Emulation/xqemu
1
0
Fork 0
mirror of https://github.com/xqemu/xqemu.git synced 2025-04-02 11:11:56 -04:00
Code Issues Projects Releases Packages Wiki Activity
xqemu/accel
History
Exact
Markus Armbruster 79b9d4bde7 accel: Unbreak accelerator fallback 
When the user specifies a list of accelerators, we pick the first one
that initializes successfully.  Recent commit 1a3ec8c156 broke that.
Reproducer:

    $ qemu-system-x86_64 --machine accel=xen:tcg
    xencall: error: Could not obtain handle on privileged command interface: No such file or directory
    xen be core: xen be core: can't open xen interface
    can't open xen interface
    qemu-system-x86_64: failed to initialize Xen: Operation not permitted
    qemu-system-x86_64: /home/armbru/work/qemu/qom/object.c:436: object_set_accelerator_compat_props: Assertion `!object_compat_props[0]' failed.

Root cause: we register accelerator compat properties even when the
accelerator fails.  The failed assertion is
object_set_accelerator_compat_props() telling us off.  Fix by calling
it only for the accelerator that succeeded.

Fixes: 1a3ec8c156
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20190401090827.20793-6-armbru@redhat.com>
2019-04-02 13:50:09 +02:00
..
kvm trace-events: Consistently point to docs/devel/tracing.txt 2019-03-22 16:17:37 +00:00
stubs tcg: simplify !CONFIG_TCG handling of tb_invalidate_* 2018-07-02 15:41:18 +02:00
tcg trace-events: Consistently point to docs/devel/tracing.txt 2019-03-22 16:17:37 +00:00
accel.c accel: Unbreak accelerator fallback 2019-04-02 13:50:09 +02:00
Makefile.objs kvm: add memory encryption context 2018-03-13 12:04:03 +01:00