Markus Armbruster 0ca7b11709 qapi: Tighten QAPISchemaFOO.check() assertions ... When we introduced the QAPISchema intermediate representation (commit ac88219a6c), we took a shortcut: we left check_exprs() & friends alone instead of moving semantic checks into the QAPISchemaFOO.check(). check_exprs() still checks and reports errors, and the .check() assert check_exprs() did the job. There are a few gaps, though. QAPISchemaArrayType.check() neglects to assert the element type is not an array. Add the assertion. QAPISchemaObjectTypeVariants.check() neglects to assert the tag member is not optional. Add the assertion. It neglects to assert the tag member is not conditional. Add the assertion. It neglects to assert we actually have variants. Add the assertion. It asserts the variants are object types, but neglects to assert they don't have variants. Tighten the assertion. QAPISchemaObjectTypeVariants.check_clash() has the same issue. However, it can run only after .check(). Delete the assertion instead of tightening it. QAPISchemaAlternateType.check() neglects to assert the branch types don't conflict. Fixing that isn't trivial, so add just a TODO comment for now. It'll be resolved later in this series. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20190927134639.4284-2-armbru@redhat.com>		2019-09-28 17:17:18 +02:00
..
__init__.py
commands.py	qapi: Permit 'boxed' with empty type	2019-09-24 14:07:22 +02:00
common.py	qapi: Tighten QAPISchemaFOO.check() assertions	2019-09-28 17:17:18 +02:00
doc.py	qapi: Allow documentation for features	2019-06-12 18:35:57 +02:00
events.py	qapi: Adjust frontend errors to say enum value, not member	2019-09-24 14:07:22 +02:00
introspect.py	qapi: Add feature flags to struct types	2019-06-12 18:34:26 +02:00
types.py	qapi: Add feature flags to struct types	2019-06-12 18:34:26 +02:00
visit.py	qapi: Add feature flags to struct types	2019-06-12 18:34:26 +02:00