mirror of
https://github.com/fail0verflow/switch-linux.git
synced 2025-05-04 02:34:21 -04:00
tracing/filter: Remove empty subsystem and its directory
Remove empty subsystem and its directory when module unload. Before patch: # rmmod trace-events-sample.ko # ls sample enable filter After patch: # rmmod trace-events-sample.ko # ls sample ls: cannot access sample: No such file or directory Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> Acked-by: Tom Zanussi <tzanussi@gmail.com> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <4A55A8BE.9010707@cn.fujitsu.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
parent
c5cb183608
commit
dc82ec98a4
2 changed files with 32 additions and 1 deletions
|
@ -757,6 +757,7 @@ struct event_subsystem {
|
||||||
const char *name;
|
const char *name;
|
||||||
struct dentry *entry;
|
struct dentry *entry;
|
||||||
void *filter;
|
void *filter;
|
||||||
|
int nr_events;
|
||||||
};
|
};
|
||||||
|
|
||||||
struct filter_pred;
|
struct filter_pred;
|
||||||
|
|
|
@ -851,9 +851,11 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
|
||||||
|
|
||||||
/* First see if we did not already create this dir */
|
/* First see if we did not already create this dir */
|
||||||
list_for_each_entry(system, &event_subsystems, list) {
|
list_for_each_entry(system, &event_subsystems, list) {
|
||||||
if (strcmp(system->name, name) == 0)
|
if (strcmp(system->name, name) == 0) {
|
||||||
|
system->nr_events++;
|
||||||
return system->entry;
|
return system->entry;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/* need to create new entry */
|
/* need to create new entry */
|
||||||
system = kmalloc(sizeof(*system), GFP_KERNEL);
|
system = kmalloc(sizeof(*system), GFP_KERNEL);
|
||||||
|
@ -871,6 +873,7 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
|
||||||
return d_events;
|
return d_events;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
system->nr_events = 1;
|
||||||
system->name = kstrdup(name, GFP_KERNEL);
|
system->name = kstrdup(name, GFP_KERNEL);
|
||||||
if (!system->name) {
|
if (!system->name) {
|
||||||
debugfs_remove(system->entry);
|
debugfs_remove(system->entry);
|
||||||
|
@ -905,6 +908,32 @@ event_subsystem_dir(const char *name, struct dentry *d_events)
|
||||||
return system->entry;
|
return system->entry;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void remove_subsystem_dir(const char *name)
|
||||||
|
{
|
||||||
|
struct event_subsystem *system;
|
||||||
|
|
||||||
|
if (strcmp(name, TRACE_SYSTEM) == 0)
|
||||||
|
return;
|
||||||
|
|
||||||
|
list_for_each_entry(system, &event_subsystems, list) {
|
||||||
|
if (strcmp(system->name, name) == 0) {
|
||||||
|
if (!--system->nr_events) {
|
||||||
|
struct event_filter *filter = system->filter;
|
||||||
|
|
||||||
|
debugfs_remove_recursive(system->entry);
|
||||||
|
list_del(&system->list);
|
||||||
|
if (filter) {
|
||||||
|
kfree(filter->filter_string);
|
||||||
|
kfree(filter);
|
||||||
|
}
|
||||||
|
kfree(system->name);
|
||||||
|
kfree(system);
|
||||||
|
}
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
static int
|
static int
|
||||||
event_create_dir(struct ftrace_event_call *call, struct dentry *d_events,
|
event_create_dir(struct ftrace_event_call *call, struct dentry *d_events,
|
||||||
const struct file_operations *id,
|
const struct file_operations *id,
|
||||||
|
@ -1079,6 +1108,7 @@ static void trace_module_remove_events(struct module *mod)
|
||||||
list_del(&call->list);
|
list_del(&call->list);
|
||||||
trace_destroy_fields(call);
|
trace_destroy_fields(call);
|
||||||
destroy_preds(call);
|
destroy_preds(call);
|
||||||
|
remove_subsystem_dir(call->system);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Add table
Reference in a new issue