Emulation/switch-linux
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-linux.git synced 2025-05-04 02:34:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Input: mousedev - fix memory leak

Browse source 
Apparently, "while true; do cat </dev/null >/dev/input/mice; done" causes
an OOM in a short amount of time. Funny that nobody noticed, it actually
is very easy to trigger just by switching between VT1 and VT7...

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Kimball Murray 2006-01-29 21:50:59 -05:00 • committed by Dmitry Torokhov
parent 5ae08f80ec
commit 74570d413c
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/input/mousedev.c
View file

@ -356,7 +356,7 @@ static void mousedev_free(struct mousedev *mousedev)
kfree(mousedev); kfree(mousedev);
} }
static int mixdev_release(void) static void mixdev_release(void)
{ {
struct input_handle *handle; struct input_handle *handle;
@ -370,8 +370,6 @@ static int mixdev_release(void)
mousedev_free(mousedev); mousedev_free(mousedev);
} }
} }
return 0;
} }
static int mousedev_release(struct inode * inode, struct file * file) static int mousedev_release(struct inode * inode, struct file * file)
@ -384,9 +382,8 @@ static int mousedev_release(struct inode * inode, struct file * file)
if (!--list->mousedev->open) { if (!--list->mousedev->open) {
if (list->mousedev->minor == MOUSEDEV_MIX) if (list->mousedev->minor == MOUSEDEV_MIX)
return mixdev_release(); mixdev_release();
else if (!mousedev_mix.open) {
if (!mousedev_mix.open) {
if (list->mousedev->exist) if (list->mousedev->exist)
input_close_device(&list->mousedev->handle); input_close_device(&list->mousedev->handle);
else else