Commit graph

115 commits

Author SHA1 Message Date
Hubert Maier
63b7129f12
JANITORIAL: BLADERUNNER: Fix typos in comments 2024-07-28 11:23:11 +03:00
antoniou79
0f7ee148ea BLADERUNNER: Methods for debugging animations 2023-07-05 14:57:58 +03:00
antoniou79
c9016cb2f2 BLADERUNNER: Notes and minor fixes for sound
Also added a dedicated debugSound channel for debugging

Fixes include closer conformance to original code (for entering/exiting ESPER and VK), and a change in assigning a track slot to a new track with priority equal to the lowest existing (it will now take the place of the old stored track). Also Music::adjustVolume() now takes the target volume as argument and stores it in the track volume field similar to how Music::adjustPan works.
2023-04-24 09:43:51 +03:00
antoniou79
ded1ec7840 BLADERUNNER: Fix sound localization for MA04 TV
M04 scene exists in two sets (kSetMA04 and kSetMA02_MA04)

So better to do the check based on kSetPS05
2022-07-03 16:33:47 +03:00
antoniou79
42a0025aed BLADERUNNER: Support secondary subtitles
Main for debugging and fun stats in shooting range and VK test for now
2022-06-30 01:00:06 +03:00
antoniou79
52e283a758 BLADERUNNER: Use static const for screen dimensions
Instead of the literals 640 for width and 480 for height
2022-05-11 23:07:38 +03:00
Eugene Sandulenko
abea37c9bb
ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
antoniou79
39b2209a80 BLADERUNNER: Add proper balance to Maggie sounds 2021-07-10 19:15:41 +03:00
antoniou79
4dcbd07148 BLADERUNNER: Fix actor voices with wrong balance
Some voices have bad pan, because the actors are not actually in the scene/dr06

This happens because on occasion (eg. TV news) some voices will be coming from an object on screen
but the game would still calculate the actor's position (and produce an awry pan value, since there is no such actor in the scene)
Addresses report: https://bugs.scummvm.org/ticket/11339
But covers more cases than just the TV voices.
2021-06-30 22:42:58 +03:00
antoniou79
08d95bae75 BLADERUNNER: Fix Gordo walking on air and floating in NR02
Original bug - If McCoy exits and re-enters quickly while Gordo walks to podium

Related to the movementTrackWaypointReached() while McCoy is not on the actor's set
2021-06-17 08:44:20 +03:00
antoniou79
f3113cf45d BLADERUNNER: More precise naming for time delay vars and parameters
Also use u suffix for unsigned int literal parameters (WIP)
2021-06-14 16:27:19 +03:00
antoniou79
8be60bb257 BLADERUNNER: Special mark for clues shared with Mainframe
These changes are for Restored Content

The special mark is a different background color, and applies only in KIA when hacked with Bob's hack.
Also tweaked the Mainframe voiceover reporting "no clues transferred" to refer to both uploading and downloading
and only play once at the end (when applicable)
2021-05-31 13:24:05 +03:00
antoniou79
f4fed91a3e BLADERUNNER: Don't upload intangible clues to Mainframe
Change only for Restored Content mode

If KIA hacking is to be important, the player must be able to control exactly what is uploaded to Mainframe.
Intangible clues do not show up in KIA, so the player cannot control sharing them with Mainframe.
Most of them are supposed to not be shared anyway (or some are wrongly set as Intangible and will be fixed in a future bug fix).
Also in Restored Content mode, the mainframe reports (with voiced quote) if clues have been transfered,
so the player would be confused if intangible clues were transfered, since they won't appear in the KIA.
2021-05-31 02:03:11 +03:00
antoniou79
3c61365692 BLADERUNNER: Fix bad boundbox for corpses
Some of these issues were caused by commit 186de62ffb

Others were original bugs (mutants 2 and 3), and both rats.
This commit includes a fix for Grayford's death animation when shot (in Act 4)
2021-04-17 01:45:38 +03:00
antoniou79
186de62ffb BLADERUNNER: Clean up and synch screenRectangle and bbox
For actors and their corresponding screenObjects

This should fix the issue with Sadik's remnant hitbox in the middle of the bridge at UG18
2020-09-04 23:35:34 +03:00
Thanasis Antoniou
11adaa4f3d BLADERUNNER: Add engine option to disable stamina drain
Allows not having to constantly click the mouse to keep McCoy from slowing down

Even though this was a bug in the original game, having this option re-creates the original experience of McCoy running quite fast (still keeping the 30 fps limit) and not slowing down when the player stops clicking.
2020-02-27 20:27:29 +02:00
Thanasis Antoniou
9d3d87e678 BLADERUNNER: Rename script methods that refer to Set
A few methods were named as though refering to Scene Ids, but are refering to Set Ids

enteredScene, EnteredScene, otherAgentExitedThisScene,OtherAgentExitedThisScene, otherAgentEnteredThisScene, OtherAgentEnteredThisScene were renamed respectively to enteredSet, EnteredSet, otherAgentExitedThisSet,OtherAgentExitedThisSet, otherAgentEnteredThisSet, OtherAgentEnteredThisSet
2020-02-24 21:43:34 +02:00
Thanasis Antoniou
cd076b26ae BLADERUNNER: Using preincrement and pre-decrease where possible
In case the compiler won't optimize such cases
2020-02-24 21:24:06 +02:00
Thanasis Antoniou
d4c659610d BLADERUNNER: Fixes for McCoy's stamina system and drain
The original game had broken stamina system we have it fixed.

This means that in vanilla mode, McCoy's stamina will drain fast if the player does not click the mouse, but he will increase speed up to a max, if the player keeps clicking the mouse.
In Restored Content, we allow McCoy to keep his speed (so that the player does not have to keep clicking); the stamina drain will still kick in but it will be at a slower rate and practically won't be noticeable most of the time.
2020-02-05 18:28:46 +02:00
Thanasis Antoniou
8791a89554 BLADERUNNER: Some clarification comments for methods 2020-02-04 17:55:27 +02:00
Thanasis Antoniou
c4d62cedf9 BLADERUNNER: Spelling correction in comment 2019-10-25 01:46:36 +03:00
D G Turner
522c5b6548 BLADERUNNER: Add Some Missing Switch Default Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-10-04 01:34:31 +01:00
Thanasis Antoniou
ac912a5023 BLADERUNNER: Revert previous changes in clues listing
Keep the important bug fix which was in KIASectionSuspects::populateAcquiredClues

Some of the changes in the previous commit were due to confusing the role of the getClueIdByIndex method
2019-09-05 13:17:53 +03:00
Thanasis Antoniou
5941ab7858 BLADERUNNER: Fix displaying of clues in KIA
Fixes bug where clues with no type would appear in KIA sections

"End of Act 2" would appear in Sadik's and Clovis' suspect pages, and in Bradbury crime page, whereas Sadik's photo would not appear in Sadik's page.
2019-09-05 10:39:51 +03:00
Thanasis Antoniou
ac3ed34610 BLADERUNNER: Fix restored walkers idle behavior and AI_Movement_Track_Append_With_Facing 2019-08-28 21:32:12 +03:00
Thanasis Antoniou
c8a23cc401 BLADERUNNER: Fix unsorted args for getRandomNumberRng
Fix for bug #11034
2019-07-29 13:57:56 +03:00
Thanasis Antoniou
af9ec2f691 BLADERUNNER: Revert uint32 vars to int32 if they could be init to -1 2019-07-22 01:09:23 +03:00
Thanasis Antoniou
caa4578add BLADERUNNER: Use unsigned 32bit diff for time durations 2019-07-17 19:09:15 +03:00
Peter Kohaut
39e4fdb98c BLADERUNNER: Use ScummVM word wrapping algorithm 2019-07-16 21:56:33 +02:00
Thanasis Antoniou
c9baa9867c BLADERUNNER: Possible fix for facing angle assertion fault 2019-07-11 07:26:33 +03:00
Thanasis Antoniou
f3cdbd2ea9 BLADERUNNER: _playerActorIdle should affect McCoy only
Should be set or cleared only when McCoy is the actor who is walking and affect only McCoy
2019-06-22 11:01:39 +03:00
Thanasis Antoniou
35daa692af BLADERUNNER: Fix bad timer initialization for actors after LOAD 2019-05-31 16:43:10 +03:00
Thanasis Antoniou
203d82a1a0 BLADERUNNER: Officers and combat bugfixes part 1
The debug messages and comments will all be removed after this series of fixes
2019-05-20 13:12:06 +03:00
Thanasis Antoniou
618d48dde8 BLADERUNNER: Mainframe talkie restored 2019-05-13 03:29:00 +03:00
Thanasis Antoniou
96660273fd BLADERUNNER: Fix bad new game pos for player 2019-05-09 19:18:08 +03:00
Peter Kohaut
d8ba527cf0 BLADERUNNER: Fix Moraji floating in DR04 2019-05-05 22:16:28 +02:00
Thanasis Antoniou
d666eb154a BLADERUNNER: Fix rats re-spawn and UG09, UG13 bad paths
UG09 bad path allowed McCoy to teleport to the pipe top left. UG13, when elevator was up McCoy could walk in the empty chute
2019-05-04 17:25:34 +03:00
Thanasis Antoniou
a9404284c3 BLADERUNNER: Fix Officer Leary crowd interrogation
He will now resume interrogation after McCoy interrupts him

Also used named constants for timers
2019-04-09 16:32:51 +03:00
Thanasis Antoniou
f04705084c BLADERUNNER: Support wait for dialogue queues to finish
Fixes a Crazylegs bug where he can interrupt himself

Could probably be used elsewhere if there are any other such cases.
2019-04-04 21:03:10 +03:00
Thanasis Antoniou
6e45a702a2 BLADERUNNER: Moonbus fixes (Izo and Luther)
Also fixed a typo that resulted in Izo's corpse persisting past chapter 2 at RC03
2019-03-28 01:33:24 +02:00
Peter Kohaut
45831a7324 BLADERUNNER: Fixed McCoy anim in spinner at PS01
McCoy will not disappear prematurely in PS01 when he enters the spinner.
2019-03-09 22:16:38 +01:00
Thanasis Antoniou
90688204d2 BLADERUNNER: Subtitles code improvements
Allow for 4 lines of subtitles, but start from using 2 lines by default

Also added debugger command to allow for immediate text testing for subtitles
2019-03-09 20:01:29 +02:00
Peter Kohaut
d4e7e957b0 BLADERUNNER: Fixed panning of speech
Cleanup of other sound pannings
2019-03-06 20:41:02 +01:00
Peter Kohaut
59f4893547 BLADERUNNER: Fixed stereo balance for speech 2019-03-04 19:43:45 +01:00
Peter Kohaut
9c25be9121 BLADERUNNER: Cleanup of TODO notes 2019-03-04 19:43:36 +01:00
Thanasis Antoniou
ada6947918 BLADERUNNER: Fix Zuben not flinching when shot at 2019-03-04 12:14:29 +02:00
Peter Kohaut
f70251819a BLADERUNNER: Fixed CppCheck warnings
Rat interaction at UG15 is now working exactly as in the original game.
Before the bridge didn't break if player shot the rat on it.
2019-02-23 11:39:54 +01:00
Thanasis Antoniou
68f9acad0d BLADERUNNER: Restore acquireCluesByRelations checks 2019-02-23 04:18:39 +02:00
Peter Kohaut
4886b0581e BLADERUNNER: Fix Coverity issues 2019-02-20 23:02:05 +01:00
Peter Kohaut
60a30b904b BLADERUNNER: Added shorty mode
Available via ScummVM game options
2019-02-10 20:34:05 +01:00