Commit graph

374 commits

Author SHA1 Message Date
Unknown W. Brackets
6da10463f9 Debugger: Make reg names safer, stop using v000.
Better to use S000, etc. as that's more clear throughout.
2023-04-29 09:48:33 -07:00
Henrik Rydgård
6945deec01 Replace a LOT of sprintf with snprintf, and a few strcpy with truncate_cpy 2023-04-28 21:04:05 +02:00
Henrik Rydgård
39d7651866
Merge pull request #17270 from unknownbrackets/debugger-cond
Debugger: Add memory breakpoint conditions
2023-04-12 23:13:26 +02:00
Henrik Rydgård
178fe27263
Merge pull request #17269 from unknownbrackets/debugger-minor
Debugger: Avoid unaligned reads in expressions
2023-04-12 10:38:08 +02:00
Unknown W. Brackets
9cebfc31b3 Debugger: Avoid unaligned reads in expressions.
Potentially, a watch or break condition could crash if it was unaligned
between mirrors.  This might happen if it's not the condition you wanted,
especially.  Play it safe.
2023-04-12 01:14:30 -07:00
Unknown W. Brackets
39bf8956ca Debugger: Windows UI for memory bp conditions. 2023-04-12 01:07:56 -07:00
Unknown W. Brackets
1e84047583 Debugger: Cleanup Windows breakpoint dialog.
Just cleanup of how its callback works.
2023-04-12 01:07:56 -07:00
Nemoumbra
5bf22c15d0 sceKernelPrintf improvement, QOL adjustments 2023-04-11 15:47:50 +03:00
Unknown W. Brackets
5629b01dc9 Debugger: Accept format for watches. 2023-04-09 16:39:25 -07:00
Henrik Rydgård
7f60acf898
Merge pull request #17259 from unknownbrackets/debugger-minor
A few more debugger things
2023-04-09 22:25:04 +02:00
Unknown W. Brackets
2374696d65 Debugger: Show vector load/store previews. 2023-04-09 11:09:36 -07:00
Unknown W. Brackets
f31a7a0582 Debugger: Update VFPU dialog more evenly.
Was previously not updating when you hit a breakpoint, stepped out, etc.
2023-04-09 10:12:54 -07:00
Unknown W. Brackets
be8a173026 Debugger: Clear button flags on lost focus.
This mouse tracking is kinda ugly.  This works around an issue where when
you removed a custom condition, the highlight would stick as if you were
dragging.
2023-04-09 10:11:37 -07:00
Henrik Rydgård
b4c766f756
Merge pull request #17256 from unknownbrackets/debugger-watch
Debugger: Add named watch expressions
2023-04-09 10:23:25 +02:00
Unknown W. Brackets
99bdb4f18a Debugger: Periodically refresh watches to be safe. 2023-04-09 00:52:03 -07:00
Unknown W. Brackets
c0fc2e65e0 Debugger: Highlight changed watches. 2023-04-09 00:47:36 -07:00
Unknown W. Brackets
85a071568c Debugger: Allow adding/removing watches. 2023-04-09 00:35:37 -07:00
Unknown W. Brackets
879e91dbf6 Debugger: Add empty watch tab for debugger.
Currently, there's nothing shown here.
2023-04-09 00:01:42 -07:00
Unknown W. Brackets
f708ab2965 Debugger: Add delete breakpoint to context menu. 2023-04-08 23:29:59 -07:00
Henrik Rydgård
3c9e968ca0
Merge pull request #17206 from unknownbrackets/debugger
Debugger: Fix memory viewer, inverted check
2023-03-29 08:07:39 +02:00
Unknown W. Brackets
a4d13d5f75 Debugger: Fix memory viewer, inverted check. 2023-03-28 22:52:01 -07:00
Nemoumbra
4a54409f09 Added new option "Copy Float (32 bit)" to Windows Debugger UI 2023-03-28 13:18:20 +03:00
Henrik Rydgård
82097b4a3b Implement NopInstruction feature in debugger
See #16975
2023-03-02 14:30:53 +01:00
Henrik Rydgård
f55782558c Debugger: Copy Address will now copy addresses for the whole selection 2023-03-02 13:59:07 +01:00
Henrik Rydgård
8b431b39ba
Wrap the display globals in a struct (#16998)
* Wrap the display globals in a struct

Makes it easier to search/replace these, for future refactorings.

* Some renaming

* Qt buildfix, also fix the Qt build on Mac (got broken with battery changes)

* Attempt at buildfixing ios

* UWP buildfix
2023-02-25 13:09:44 +01:00
Unknown W. Brackets
cbc1ed4bfe Debugger: Lock memory during stack walk.
In case of shutdown during it.
2023-02-22 21:14:33 -08:00
Henrik Rydgård
b4a91dbce5 Disable dark mode in disasm window, and the scrollbar hack 2023-01-12 01:05:06 +01:00
Henrik Rydgård
62e5a5dfc3 Rudimentary support for Windows Dark Mode. Still undocumented for Win32 apps, so ugly. 2023-01-12 00:41:25 +01:00
Unknown W. Brackets
88489bf4cc Debugger: Fix out of bounds read for unsized copy. 2023-01-04 21:42:46 -08:00
Unknown W. Brackets
7c099dc764 Debugger: Allow copy of byte range from memview. 2023-01-01 23:02:12 -08:00
Unknown W. Brackets
bba748d627 Debugger: Handle memview select right click better.
Shouldn't reset if you click inside.  Also should basically ignore
modifiers, that's how it normally behaves.
2023-01-01 22:49:04 -08:00
Unknown W. Brackets
a7101b128f Debugger: Allow memview select with keyboard. 2023-01-01 22:37:53 -08:00
Unknown W. Brackets
f66818ba80 Debugger: Allow selecting a range in memory view. 2023-01-01 22:28:29 -08:00
Unknown W. Brackets
f8064c6763 Debugger: Cleanup memview members.
Was fairly inconsistent.  This code has not changed a lot in a long time,
so let's just do a single cleanup pass before some changes.
2023-01-01 21:47:39 -08:00
Henrik Rydgård
40386bca08
Merge pull request #16688 from unknownbrackets/debugger
Debugger: Correct check of pending list item
2022-12-31 19:39:28 +01:00
Unknown W. Brackets
bfc659ab5f Debugger: Correct check of pending list item.
Since updating is async now, setting the check state should be too.
2022-12-31 09:58:24 -08:00
Unknown W. Brackets
94a7a32234 Debugger: Correct errors in breakpoint create. 2022-12-30 15:07:02 -08:00
Unknown W. Brackets
9cfcbc46e6 Global: Cleanup initialization/pointer checks.
Cleaning up a lot of cases of uninitialized data, unchecked return values
for failures, and similar.
2022-12-10 21:13:36 -08:00
Unknown W. Brackets
a7b7bf7826 Global: Set many read-only params as const.
This makes what they do and which args to use clearer, if nothing else.
2022-12-10 21:13:36 -08:00
Unknown W. Brackets
f44852bb18 Global: Cleanup virtual/override specifiers.
Also missing virtual destructors, hidden non-overrides, etc.
2022-12-10 21:13:36 -08:00
Herman Semenov
29b87e0c0b
Merge branch 'master' into master 2022-10-03 07:49:13 +00:00
Unknown W. Brackets
ac335ad61a armips: Update to UTF-8/c++17 armips. 2022-09-30 19:48:14 -07:00
lainon
3cdf72b68b Better readability and optimization insertion into container by replacing 'insert' -> 'emplace', 'push_back' -> 'emplace_back' 2022-09-30 12:35:28 +03:00
lainon
b304551747 Code readability, vec reserve() and remove excess c_str() 2022-09-30 12:31:32 +03:00
lainon
fec708489a Correct cleaning string and remove unused vars 2022-09-30 12:26:30 +03:00
Unknown W. Brackets
1233d1d376 Reporting: Disable when debugger methods used.
This won't catch all means of hacking memory, but will catch some.
Trying to reduce noise in reporting from debugging.
2022-07-30 18:21:32 -07:00
Henrik Rydgård
d3d601dced Windows fixes 2022-07-24 13:58:20 +02:00
Henrik Rydgård
858539c5b0
Merge pull request #15402 from unknownbrackets/debugger-highlight
GE Debugger: Highlight changed state values
2022-02-13 21:42:43 +01:00
Unknown W. Brackets
b654ee9d44 Debugger: Allow custom draw and generic lists. 2022-02-13 10:22:38 -08:00
Unknown W. Brackets
ea6c42aafb Debugger: Avoid scroll on breakpoint add. 2022-02-13 07:57:54 -08:00