From e4127890ec6dea5e79d35b69a446f8e8c4caf3f5 Mon Sep 17 00:00:00 2001 From: "Unknown W. Brackets" Date: Sun, 17 Jun 2018 11:30:22 -0700 Subject: [PATCH] Vulkan: Fix some missing switch warnings. Might as well prefer a virtual GPU over a CPU maybe... --- Common/Vulkan/VulkanContext.cpp | 5 +++++ Common/Vulkan/VulkanLoader.cpp | 2 ++ UI/GameSettingsScreen.cpp | 3 ++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Common/Vulkan/VulkanContext.cpp b/Common/Vulkan/VulkanContext.cpp index ffe7ba5a3f..3b43e80c02 100644 --- a/Common/Vulkan/VulkanContext.cpp +++ b/Common/Vulkan/VulkanContext.cpp @@ -444,12 +444,17 @@ int VulkanContext::GetBestPhysicalDevice() { case VK_PHYSICAL_DEVICE_TYPE_CPU: score += 1; break; + case VK_PHYSICAL_DEVICE_TYPE_VIRTUAL_GPU: + score += 2; + break; case VK_PHYSICAL_DEVICE_TYPE_DISCRETE_GPU: score += 20; break; case VK_PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU: score += 10; break; + default: + break; } if (props.vendorID == VULKAN_VENDOR_AMD) { score += 5; diff --git a/Common/Vulkan/VulkanLoader.cpp b/Common/Vulkan/VulkanLoader.cpp index 0d41785a28..04755dc555 100644 --- a/Common/Vulkan/VulkanLoader.cpp +++ b/Common/Vulkan/VulkanLoader.cpp @@ -313,6 +313,8 @@ bool VulkanMayBeAvailable() { case VK_PHYSICAL_DEVICE_TYPE_VIRTUAL_GPU: anyGood = true; break; + default: + break; } // TODO: Should also check queuefamilyproperties for a GRAPHICS queue family? Oh well. } diff --git a/UI/GameSettingsScreen.cpp b/UI/GameSettingsScreen.cpp index 0ad1a44cf5..2834218006 100644 --- a/UI/GameSettingsScreen.cpp +++ b/UI/GameSettingsScreen.cpp @@ -104,8 +104,9 @@ bool DoesBackendSupportHWTess() { case GPUBackend::VULKAN: case GPUBackend::DIRECT3D11: return true; + default: + return false; } - return false; } static std::string PostShaderTranslateName(const char *value) {