Emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2025-04-02 11:01:50 -04:00
Code Issues Projects Releases Packages Wiki Activity

Debugger: Speed up GetFunctionSize().

Browse source 
Tested games with lots of functions, it's just never worth generating the
full active symbols.  Direct lookup saves 0.005s startup on desktop in a
typical game.
This commit is contained in:
Unknown W. Brackets 2021-12-04 14:49:50 -08:00
parent 676ed6c15d
commit e2425a1e00
1 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
Core/Debugger/SymbolMap.cpp
View file

@ -31,6 +31,7 @@
#include <algorithm>
#include <memory>
#include <unordered_map>
#include "zlib.h"
@ -619,8 +620,31 @@ u32 SymbolMap::FindPossibleFunctionAtAfter(u32 address) {
}
u32 SymbolMap::GetFunctionSize(u32 startAddress) {
if (activeNeedUpdate_)
UpdateActiveSymbols();
if (activeNeedUpdate_) {
std::lock_guard<std::recursive_mutex> guard(lock_);
// This is common, from the jit. Direct lookup is faster than updating active symbols.
auto mod = activeModuleEnds.lower_bound(startAddress);
std::pair<int, u32> funcKey;
if (mod == activeModuleEnds.end()) {
// Could still be mod 0, backwards compatibility.
if (!sawUnknownModule)
return INVALID_ADDRESS;
funcKey.first = 0;
funcKey.second = startAddress;
} else {
if (mod->second.start > startAddress)
return INVALID_ADDRESS;
funcKey.first = mod->second.index;
funcKey.second = startAddress - mod->second.start;
}
auto func = functions.find(funcKey);
if (func == functions.end())
return INVALID_ADDRESS;
return func->second.size;
}
std::lock_guard<std::recursive_mutex> guard(lock_);
auto it = activeFunctions.find(startAddress);
@ -684,7 +708,7 @@ void SymbolMap::UpdateActiveSymbols() {
return;
}
std::map<int, u32> activeModuleIndexes;
std::unordered_map<int, u32> activeModuleIndexes;
for (auto it = activeModuleEnds.begin(), end = activeModuleEnds.end(); it != end; ++it) {
activeModuleIndexes[it->second.index] = it->second.start;
}