From cebb2ea96eacb163c75fa4be3ae6a100234d1236 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= <hrydgard@gmail.com>
Date: Mon, 4 Nov 2024 01:11:42 +0100
Subject: [PATCH] Add missing return statement from
 PBPReader::GetSubFileAsString.  Compiler should have rejected this..

---
 .gitignore             | 2 ++
 Core/ELF/PBPReader.cpp | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index 2b103bf0d8..8f7ea14337 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,6 +57,7 @@ include/glslang/build_info.h
 
 # For ppsspp.ini, etc.
 ppsspp.ini
+imgui.ini
 PPSSPPControls.dat
 
 # Qt Linguist files
@@ -101,6 +102,7 @@ local.properties
 r.sh
 Windows/compileData*
 Windows/*.ipch
+Windows/imgui.ini
 
 # For vim
 *.swp
diff --git a/Core/ELF/PBPReader.cpp b/Core/ELF/PBPReader.cpp
index 9306585f12..3dfed9b584 100644
--- a/Core/ELF/PBPReader.cpp
+++ b/Core/ELF/PBPReader.cpp
@@ -95,8 +95,10 @@ bool PBPReader::GetSubFileAsString(PBPSubFile file, std::string *out) const {
 		ERROR_LOG(Log::Loader, "PBP file read truncated: %d -> %d", (int)expected, (int)bytes);
 		if (bytes < expected) {
 			out->resize(bytes);
+			// should we still return true here?
 		}
 	}
+	return true;
 }
 
 PBPReader::~PBPReader() {