Emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2025-04-02 11:01:50 -04:00
Code Issues Projects Releases Packages Wiki Activity

Make vertexFullAlpha-in-register work the same as on ARM.

Browse source
This commit is contained in:
Henrik Rydgård 2023-06-11 17:13:31 +02:00
parent a164f77f47
commit c9aa3479a4
1 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
GPU/Common/VertexDecoderX86.cpp
View file

@ -203,15 +203,10 @@ JittedVertexDecoder VertexDecoderJitCache::Compile(const VertexDecoder &dec, int
MOVUPS(MDisp(ESP, 80), XMM9); MOVUPS(MDisp(ESP, 80), XMM9);
#endif #endif
// Initialize alpha reg if possible. TODO: Only do if color values with alpha are used. // Initialize alpha reg.
#if PPSSPP_ARCH(AMD64) if (dec.col) {
if (RipAccessible(&gstate_c.vertexFullAlpha)) { MOV(32, R(alphaReg), Imm32(1));
MOV(8, R(alphaReg), M(&gstate_c.vertexFullAlpha)); // rip accessible
} else {
MOV(PTRBITS, R(tempReg1), ImmPtr(&gstate_c.vertexFullAlpha));
MOV(8, R(alphaReg), MatR(tempReg1));
} }
#endif
bool prescaleStep = false; bool prescaleStep = false;
// Look for prescaled texcoord steps // Look for prescaled texcoord steps
@ -286,11 +281,16 @@ JittedVertexDecoder VertexDecoderJitCache::Compile(const VertexDecoder &dec, int
// Writeback alpha reg // Writeback alpha reg
#if PPSSPP_ARCH(AMD64) #if PPSSPP_ARCH(AMD64)
if (RipAccessible(&gstate_c.vertexFullAlpha)) { if (dec.col) {
MOV(8, M(&gstate_c.vertexFullAlpha), R(alphaReg)); // rip accessible CMP(32, R(alphaReg), Imm32(1));
} else { FixupBranch alphaJump = J_CC(CC_NE, false);
MOV(PTRBITS, R(tempReg1), ImmPtr(&gstate_c.vertexFullAlpha)); if (RipAccessible(&gstate_c.vertexFullAlpha)) {
MOV(8, MatR(tempReg1), R(alphaReg)); MOV(8, M(&gstate_c.vertexFullAlpha), Imm8(0)); // rip accessible
} else {
MOV(PTRBITS, R(tempReg1), ImmPtr(&gstate_c.vertexFullAlpha));
MOV(8, MatR(tempReg1), Imm8(0)); // rip accessible
}
SetJumpTarget(alphaJump);
} }
#endif #endif
@ -954,6 +954,7 @@ void VertexDecoderJitCache::Jit_Color8888() {
CMP(32, R(tempReg1), Imm32(0xFF000000)); CMP(32, R(tempReg1), Imm32(0xFF000000));
FixupBranch skip = J_CC(CC_AE, false); FixupBranch skip = J_CC(CC_AE, false);
#if PPSSPP_ARCH(AMD64) #if PPSSPP_ARCH(AMD64)
// Would like to use CMOV or SetCC but CMOV doesn't take immediates and SetCC isn't right. So...
XOR(32, R(alphaReg), R(alphaReg)); XOR(32, R(alphaReg), R(alphaReg));
#else #else
if (RipAccessible(&gstate_c.vertexFullAlpha)) { if (RipAccessible(&gstate_c.vertexFullAlpha)) {