Merge pull request #18389 from hrydgard/disable-negative-messages

Redump checks: Disable negative messages
This commit is contained in:
Henrik Rydgård 2023-10-30 07:54:58 -06:00 committed by GitHub
commit b01ec488d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -321,27 +321,28 @@ void GameScreen::render() {
found = true; found = true;
} }
} }
tvVerified_->SetVisibility(UI::V_VISIBLE);
if (found) { if (found) {
tvVerified_->SetText(ga->T("ISO OK according to the Redump project")); tvVerified_->SetText(ga->T("ISO OK according to the Redump project"));
tvVerified_->SetLevel(NoticeLevel::SUCCESS); tvVerified_->SetLevel(NoticeLevel::SUCCESS);
tvVerified_->SetVisibility(UI::V_VISIBLE);
} else { } else {
tvVerified_->SetText(ga->T("CRC checksum does not match, bad or modified ISO")); // Like the other messages below, disabled until we have a database we have confidence in.
tvVerified_->SetLevel(NoticeLevel::ERROR); // tvVerified_->SetText(ga->T("CRC checksum does not match, bad or modified ISO"));
// tvVerified_->SetLevel(NoticeLevel::ERROR);
} }
} else { } else {
tvVerified_->SetText(ga->T("Game ID unknown - not in the Redump database")); // tvVerified_->SetText(ga->T("Game ID unknown - not in the Redump database"));
tvVerified_->SetVisibility(UI::V_VISIBLE); // tvVerified_->SetVisibility(UI::V_VISIBLE);
tvVerified_->SetLevel(NoticeLevel::WARN); // tvVerified_->SetLevel(NoticeLevel::WARN);
} }
} else if (!isHomebrew_) { } else if (!isHomebrew_) {
GameDBInfo dbInfo; GameDBInfo dbInfo;
if (tvVerified_) { if (tvVerified_) {
std::vector<GameDBInfo> dbInfos; std::vector<GameDBInfo> dbInfos;
if (!g_gameDB.GetGameInfos(info->id_version, &dbInfos)) { if (!g_gameDB.GetGameInfos(info->id_version, &dbInfos)) {
tvVerified_->SetText(ga->T("Game ID unknown - not in the ReDump database")); // tvVerified_->SetText(ga->T("Game ID unknown - not in the ReDump database"));
tvVerified_->SetVisibility(UI::V_VISIBLE); // tvVerified_->SetVisibility(UI::V_VISIBLE);
tvVerified_->SetLevel(NoticeLevel::WARN); // tvVerified_->SetLevel(NoticeLevel::WARN);
} else if (info->gameSizeUncompressed != 0) { // don't do this check if info still pending } else if (info->gameSizeUncompressed != 0) { // don't do this check if info still pending
bool found = false; bool found = false;
for (auto &dbInfo : dbInfos) { for (auto &dbInfo : dbInfos) {
@ -351,9 +352,9 @@ void GameScreen::render() {
} }
} }
if (!found) { if (!found) {
tvVerified_->SetText(ga->T("File size incorrect, bad or modified ISO")); // tvVerified_->SetText(ga->T("File size incorrect, bad or modified ISO"));
tvVerified_->SetVisibility(UI::V_VISIBLE); // tvVerified_->SetVisibility(UI::V_VISIBLE);
tvVerified_->SetLevel(NoticeLevel::ERROR); // tvVerified_->SetLevel(NoticeLevel::ERROR);
} else { } else {
tvVerified_->SetText(ga->T("Click \"Calculate CRC\" to verify ISO")); tvVerified_->SetText(ga->T("Click \"Calculate CRC\" to verify ISO"));
tvVerified_->SetVisibility(UI::V_VISIBLE); tvVerified_->SetVisibility(UI::V_VISIBLE);