From 8efd67280d35c1e0a56033e389b4abe1e17b539e Mon Sep 17 00:00:00 2001 From: The Dax Date: Thu, 6 Mar 2014 08:16:19 -0500 Subject: [PATCH] Show unknown.png regardless of PARAM.SFO when an ISO lacks the file. It's better than showing a black rectangle with nothing in it for broken or homebrew ISOs. --- UI/GameInfoCache.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/UI/GameInfoCache.cpp b/UI/GameInfoCache.cpp index 79c471b91a..78dd0e502a 100644 --- a/UI/GameInfoCache.cpp +++ b/UI/GameInfoCache.cpp @@ -362,7 +362,6 @@ handleELF: info_->paramSFO.ReadSFO((const u8 *)paramSFOcontents.data(), paramSFOcontents.size()); info_->ParseParamSFO(); - ReadFileToString(&umd, "/PSP_GAME/ICON0.PNG", &info_->iconTextureData, &info_->lock); if (info_->wantBG) { ReadFileToString(&umd, "/PSP_GAME/PIC0.PNG", &info_->pic0TextureData, &info_->lock); } @@ -370,7 +369,10 @@ handleELF: } else { // Fall back to the filename for title if ISO is broken info_->title = gamePath_; - // Fall back to unknown icon if ISO is broken, override is allowed though + } + + // Fall back to unknown icon if ISO is broken/is a homebrew ISO, override is allowed though + if (!ReadFileToString(&umd, "/PSP_GAME/ICON0.PNG", &info_->iconTextureData, &info_->lock)) { size_t sz; uint8_t *contents = VFSReadFile("unknown.png", &sz); DEBUG_LOG(LOADER, "Loading unknown.png because no icon was found");