From 7ddcf62955880da485b331423ce084f64176fe93 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Thu, 4 May 2023 09:00:48 +0200 Subject: [PATCH] Change TODO to a better idea --- GPU/GPUCommonHW.cpp | 2 -- GPU/GPUCommonHW.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/GPU/GPUCommonHW.cpp b/GPU/GPUCommonHW.cpp index 9c9645be96..51cd770fe6 100644 --- a/GPU/GPUCommonHW.cpp +++ b/GPU/GPUCommonHW.cpp @@ -806,7 +806,6 @@ void GPUCommonHW::FastRunLoop(DisplayList &list) { if (info.flags & FLAG_EXECUTE) { downcount = dc; (this->*info.func)(op, diff); - // TODO: Check pc here, and break if invalid, as the func can change it. Might an have a performance impact though. dc = downcount; } } else { @@ -820,7 +819,6 @@ void GPUCommonHW::FastRunLoop(DisplayList &list) { if (flags & (FLAG_EXECUTE | FLAG_EXECUTEONCHANGE)) { downcount = dc; (this->*info.func)(op, diff); - // TODO: Check pc here, and break if invalid, as the func can change it. Might have a performance impact though. dc = downcount; } else { uint64_t dirty = flags >> 8; diff --git a/GPU/GPUCommonHW.h b/GPU/GPUCommonHW.h index c1928de99e..6ab7151f57 100644 --- a/GPU/GPUCommonHW.h +++ b/GPU/GPUCommonHW.h @@ -62,6 +62,7 @@ public: void Execute_TexFlush(u32 op, u32 diff); + // TODO: Have these return an error code if they jump to a bad address. If bad, stop the FastRunLoop. typedef void (GPUCommonHW::*CmdFunc)(u32 op, u32 diff); void FastRunLoop(DisplayList &list) override;