Emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2025-04-02 11:01:50 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix performance issue in MLB 2k games with profiler funcs

Browse source 
The two functions sceKernelReferThreadProfiler and
sceKernelReferGlobalProfiler are spammed by this game. So let's reduce
logging to DEBUG and delay the response by a tested number of ms.

Fixes #17623
This commit is contained in:
Henrik Rydgård 2023-07-05 11:43:37 +02:00
parent 65125583f8
commit 7daaab96d5
1 changed files with 14 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
Core/HLE/sceKernel.cpp
View file

@ -655,6 +655,7 @@ static int sceKernelReferSystemStatus(u32 statusPtr) {
return 0;
}
// Unused - believed to be the returned struct from sceKernelReferThreadProfiler.
struct DebugProfilerRegs {
u32 enable;
u32 systemck;
@ -678,24 +679,22 @@ struct DebugProfilerRegs {
u32 local_bus;
};
static u32 sceKernelReferThreadProfiler(u32 statusPtr) {
ERROR_LOG(SCEKERNEL, "FAKE sceKernelReferThreadProfiler()");
static u32 sceKernelReferThreadProfiler(u32 unused) {
// This seems to simply has no parameter:
// https://pspdev.github.io/pspsdk/group__ThreadMan.html#ga8fd30da51b9dc0507ac4dae04a7e4a17 ,
// And in testing it just returns null in 55 usec (which is surprisingly long).
// Can we confirm that the struct above is the right struct?
// If so, re-enable this code.
//auto regs = PSPPointer<DebugProfilerRegs>::Create(statusPtr);
// TODO: fill the struct.
//if (regs.IsValid()) {
// memset((DebugProfilerRegs *)regs, 0, sizeof(DebugProfilerRegs));
// regs.NotifyWrite("ThreadProfiler");
//}
return 0;
// So, we log only if debug logging is enabled, and sleep for a bit.
DEBUG_LOG(SCEKERNEL, "sceKernelReferThreadProfiler(%08x)", unused);
// The delay has been measured, 53-56.
return hleDelayResult(0, "refer_thread_profiler", 55);
}
static int sceKernelReferGlobalProfiler(u32 statusPtr) {
ERROR_LOG(SCEKERNEL, "UNIMPL sceKernelReferGlobalProfiler(%08x)", statusPtr);
// Ignore for now
return 0;
static int sceKernelReferGlobalProfiler(u32 unused) {
DEBUG_LOG(SCEKERNEL, "sceKernelReferGlobalProfiler(%08x)", unused);
// The delay has been measured, 53-56.
return hleDelayResult(0, "refer_thread_profiler", 55);
}
const HLEFunction ThreadManForUser[] =