From 6dbfa85bce88a61f86c93be5fb205ff9c119d133 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Tue, 25 Feb 2025 14:12:10 -0600 Subject: [PATCH] DevMenu: Hide the option to record a framedump if one is being played back --- UI/DevScreens.cpp | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/UI/DevScreens.cpp b/UI/DevScreens.cpp index 3cc16bec6a..a4c2dff681 100644 --- a/UI/DevScreens.cpp +++ b/UI/DevScreens.cpp @@ -154,17 +154,19 @@ void DevMenuScreen::CreatePopupContents(UI::ViewGroup *parent) { return UI::EVENT_DONE; }); - items->Add(new Choice(dev->T("Create frame dump")))->OnClick.Add([](UI::EventParams &e) { - gpuDebug->GetRecorder()->RecordNextFrame([](const Path &dumpPath) { - NOTICE_LOG(Log::System, "Frame dump created at '%s'", dumpPath.c_str()); - if (System_GetPropertyBool(SYSPROP_CAN_SHOW_FILE)) { - System_ShowFileInFolder(dumpPath); - } else { - g_OSD.Show(OSDType::MESSAGE_SUCCESS, dumpPath.ToVisualString(), 7.0f); - } + if (PSP_CoreParameter().fileType != IdentifiedFileType::PPSSPP_GE_DUMP) { + items->Add(new Choice(dev->T("Create frame dump")))->OnClick.Add([](UI::EventParams &e) { + gpuDebug->GetRecorder()->RecordNextFrame([](const Path &dumpPath) { + NOTICE_LOG(Log::System, "Frame dump created at '%s'", dumpPath.c_str()); + if (System_GetPropertyBool(SYSPROP_CAN_SHOW_FILE)) { + System_ShowFileInFolder(dumpPath); + } else { + g_OSD.Show(OSDType::MESSAGE_SUCCESS, dumpPath.ToVisualString(), 7.0f); + } + }); + return UI::EVENT_DONE; }); - return UI::EVENT_DONE; - }); + } // This one is not very useful these days, and only really on desktop. Hide it on other platforms. if (System_GetPropertyInt(SYSPROP_DEVICE_TYPE) == DEVICE_TYPE_DESKTOP) {