From 6592c6222a219ce9e6f019ee3135ff08e1128d7c Mon Sep 17 00:00:00 2001 From: "Unknown W. Brackets" Date: Sun, 17 Jun 2018 10:56:42 -0700 Subject: [PATCH] http: Check fread() result to avoid warning. This will cause the length not to match the result if it happens, but the client should interpret that as a server error. Also a similar error in headless. --- Core/WebServer.cpp | 3 ++- headless/StubHost.cpp | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Core/WebServer.cpp b/Core/WebServer.cpp index f5fdf68754..284c1c0333 100644 --- a/Core/WebServer.cpp +++ b/Core/WebServer.cpp @@ -163,7 +163,8 @@ static void RegisterDiscHandlers(http::Server *http, std::unordered_mapPush(buf, chunklen); } fclose(fp); diff --git a/headless/StubHost.cpp b/headless/StubHost.cpp index 82698770da..dc3520013e 100644 --- a/headless/StubHost.cpp +++ b/headless/StubHost.cpp @@ -71,7 +71,9 @@ void HeadlessHost::SendDebugScreenshot(const u8 *pixbuf, u32 w, u32 h) FILE *bmp = File::OpenCFile(comparisonScreenshot_, "rb"); if (bmp) { - fread(&header, sizeof(header), 1, bmp); + if (fread(&header, sizeof(header), 1, bmp) != 1) { + SendOrCollectDebugOutput("Failed to read original screenshot header.\n"); + } fclose(bmp); }