Use reference when possible to avoid copying.

This commit is contained in:
ANR2ME 2022-03-16 05:21:45 +07:00
parent 2b09f81ff8
commit 5e739f32b2
2 changed files with 4 additions and 4 deletions

View file

@ -1906,7 +1906,7 @@ static std::vector<std::pair<uint32_t, uint32_t>> InitPrivateIPRanges() {
bool isPrivateIP(uint32_t ip) {
static const std::vector<std::pair<uint32_t, uint32_t>> ip_ranges = InitPrivateIPRanges();
for (auto ipRange : ip_ranges) {
for (auto& ipRange : ip_ranges) {
if ((ip & ipRange.second) == (ipRange.first & ipRange.second)) // We can just use ipRange.first directly if it's already correctly formatted
return true;
}

View file

@ -1685,7 +1685,7 @@ static int sceNetAdhocPdpSend(int id, const char *mac, u32 port, void *data, int
// Non-blocking
else {
// Iterate Peers
for (auto peer : dest.peers) {
for (auto& peer : dest.peers) {
// Fill in Target Structure
struct sockaddr_in target {};
target.sin_family = AF_INET;
@ -4492,7 +4492,7 @@ static int sceNetAdhocGameModeUpdateReplica(int id, u32 infoAddr) {
gmuinfo = (GameModeUpdateInfo*)Memory::GetPointer(infoAddr);
}
for (auto gma : replicaGameModeAreas) {
for (auto& gma : replicaGameModeAreas) {
if (gma.id == id) {
if (gma.data && gma.dataUpdated) {
Memory::Memcpy(gma.addr, gma.data, gma.size);
@ -6421,7 +6421,7 @@ void sendAcceptPacket(SceNetAdhocMatchingContext * context, SceNetEtherAddr * ma
uint32_t siblingbuflen = 0;
// Parent Mode
if (context->mode == PSP_ADHOC_MATCHING_MODE_PARENT) siblingbuflen = sizeof(SceNetEtherAddr) * (countConnectedPeers(context) - 2);
if (context->mode == PSP_ADHOC_MATCHING_MODE_PARENT) siblingbuflen = (u32)sizeof(SceNetEtherAddr) * (countConnectedPeers(context) - 2);
// Sibling Count
int siblingcount = siblingbuflen / sizeof(SceNetEtherAddr);