From 50ea506b6a223a51612c81d9657a0c4be2e90ee7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Wed, 9 Aug 2023 16:16:39 +0200 Subject: [PATCH] Revert "Regression experiment: Temporarily revert to returning 0 from bad achievement memory accesses." This reverts commit a044d8ccc23167ac8f1863ebf4758b3781e4900b. --- Core/RetroAchievements.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Core/RetroAchievements.cpp b/Core/RetroAchievements.cpp index 9f6e43de9a..15740d6ce7 100644 --- a/Core/RetroAchievements.cpp +++ b/Core/RetroAchievements.cpp @@ -166,13 +166,8 @@ static uint32_t read_memory_callback(uint32_t address, uint8_t *buffer, uint32_t WARN_LOG(G3D, "RetroAchievements PeekMemory: Bad address %08x (%d bytes) (%08x was passed in)", address, num_bytes, orig_address); } - // TEMPORARY EXPERIMENT: - // Revert to returning 0. - memset(buffer, 0, num_bytes); - return num_bytes; - // This tells rcheevos that the access was bad, which should now be handled properly. - // return 0; + return 0; } Memory::MemcpyUnchecked(buffer, address, num_bytes);