Emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2025-04-02 11:01:50 -04:00
Code Issues Projects Releases Packages Wiki Activity

Do indexed draws properly with glDrawElements where possible. Fix sprite culling issue (winding order).

Browse source
This commit is contained in:
Henrik Rydgard 2012-11-16 16:43:16 +01:00
parent 7c9107030d
commit 4c1ae9e81c
1 changed files with 60 additions and 50 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
GPU/GLES/TransformPipeline.cpp
View file

@ -430,9 +430,25 @@ void TransformAndDrawPrim(void *verts, void *inds, int prim, int vertexCount, Li
indexType = forceIndexType;
}
if (indexType == 0 && prim != GE_PRIM_RECTANGLES) {
bool drawIndexed = false;
GLuint glIndexType = 0;
if (prim != GE_PRIM_RECTANGLES) {
// We can simply draw the unexpanded buffer.
numTrans = vertexCount;
switch (indexType) {
case GE_VTYPE_IDX_8BIT:
drawIndexed = true;
glIndexType = GL_UNSIGNED_BYTE;
break;
case GE_VTYPE_IDX_16BIT:
drawIndexed = true;
glIndexType = GL_UNSIGNED_SHORT;
break;
default:
drawIndexed = false;
break;
}
} else {
numTrans = 0;
drawBuffer = transformedExpanded;
@ -454,15 +470,6 @@ void TransformAndDrawPrim(void *verts, void *inds, int prim, int vertexCount, Li
}
TransformedVertex &transVtx = transformed[index];
if (prim != GE_PRIM_RECTANGLES)
{
*trans = transVtx;
trans++;
numTrans++;
}
else // We need to tesselate axis-aligned rectangles, as they're only specified by two coordinates.
{
if ((i & 1) == 0)
{
// Save this vertex so we can generate when we get the next one. Color is taken from the last vertex.
@ -476,12 +483,6 @@ void TransformAndDrawPrim(void *verts, void *inds, int prim, int vertexCount, Li
*trans = transVtx;
trans++;
// top right
*trans = transVtx;
trans->x = saved.x;
trans->uv[0] = saved.uv[0];
trans++;
// bottom right
*trans = transVtx;
trans->x = saved.x;
@ -490,16 +491,18 @@ void TransformAndDrawPrim(void *verts, void *inds, int prim, int vertexCount, Li
trans->uv[1] = saved.uv[1];
trans++;
// top right
*trans = transVtx;
trans->x = saved.x;
trans->uv[0] = saved.uv[0];
trans++;
// bottom left
*trans = transVtx;
trans->y = saved.y;
trans->uv[1] = saved.uv[1];
trans++;
// top left
*trans = transVtx;
trans++;
// bottom right
*trans = transVtx;
trans->x = saved.x;
@ -508,11 +511,14 @@ void TransformAndDrawPrim(void *verts, void *inds, int prim, int vertexCount, Li
trans->uv[1] = saved.uv[1];
trans++;
// top left
*trans = transVtx;
trans++;
numTrans += 6;
}
}
}
}
glEnableVertexAttribArray(program->a_position);
if (useTexCoord && program->a_texcoord != -1) glEnableVertexAttribArray(program->a_texcoord);
@ -524,7 +530,11 @@ void TransformAndDrawPrim(void *verts, void *inds, int prim, int vertexCount, Li
if (program->a_color0 != -1) glVertexAttribPointer(program->a_color0, 4, GL_FLOAT, GL_FALSE, vertexSize, ((uint8_t*)drawBuffer) + 5 * 4);
if (program->a_color1 != -1) glVertexAttribPointer(program->a_color1, 4, GL_FLOAT, GL_FALSE, vertexSize, ((uint8_t*)drawBuffer) + 9 * 4);
// NOTICE_LOG(G3D,"DrawPrimitive: %i", numTrans);
if (drawIndexed) {
glDrawElements(glprim[prim], numTrans, glIndexType, (GLvoid *)inds);
} else {
glDrawArrays(glprim[prim], 0, numTrans);
}
glDisableVertexAttribArray(program->a_position);
if (useTexCoord && program->a_texcoord != -1) glDisableVertexAttribArray(program->a_texcoord);
if (program->a_color0 != -1) glDisableVertexAttribArray(program->a_color0);