From 0e57cf30c7dfbb1bb0addabecbbc0f8ba0af827a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Mon, 29 Apr 2024 11:32:54 +0200 Subject: [PATCH] ARM64: Disable the JIT implementation of the vh2f instruction, not accurate --- Core/MIPS/ARM64/Arm64CompVFPU.cpp | 6 ++++++ GPU/Software/Sampler.cpp | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Core/MIPS/ARM64/Arm64CompVFPU.cpp b/Core/MIPS/ARM64/Arm64CompVFPU.cpp index d5dd416d6f..0d84f2851d 100644 --- a/Core/MIPS/ARM64/Arm64CompVFPU.cpp +++ b/Core/MIPS/ARM64/Arm64CompVFPU.cpp @@ -948,6 +948,12 @@ namespace MIPSComp { } void Arm64Jit::Comp_Vh2f(MIPSOpcode op) { + // TODO: Fix by porting the general SSE solution to NEON + // FCVTL doesn't provide identical results to the PSP hardware, according to the unit test: + // O vh2f: 00000000,400c0000,00000000,7ff00000 + // E vh2f: 00000000,400c0000,00000000,7f800380 + DISABLE; + CONDITIONAL_DISABLE(VFPU_VEC); if (js.HasUnknownPrefix()) { DISABLE; diff --git a/GPU/Software/Sampler.cpp b/GPU/Software/Sampler.cpp index 9dee5a656a..60afbd39a9 100644 --- a/GPU/Software/Sampler.cpp +++ b/GPU/Software/Sampler.cpp @@ -181,7 +181,6 @@ NearestFunc SamplerJitCache::GetByID(const SamplerID &id, size_t key, BinManager } if (!binner) { - printf("No binner, can't compile\n"); // Can't compile, let's try to do it later when there's an opportunity. compileQueue_.insert(id); return nullptr;