Addresses feedback to use consistent naming conventions as most variables are using snake_case. Also no longer passes string_view by reference as per feedback.
Bundled patches don't display when unlabeled patches are loaded (since we can't guarantee they don't collide). This warns the user that bundled patches are hidden when unlabeled patches are loaded. (The warning hides when no unlabeled patches are loaded)
The Cheats Settings menu was failing to reload cheats when pressing the button. This meant if you enabled a cheat, made changes, and clicked reload, there would be no updates in behavior.
This was due to the reload button getting wired to the function that refreshes the list of cheats, rather than the function that refreshes the list AND reloads the actual enabled cheats.
This now calls the right function and when reloading, any changes thart were saved to the cheat will now be present.
Also improves behaviour parity between Qt and Fullscreen UI,
since the latter used to prompt for system reset even if the game had
no RetroAchievements entry.
* Pad: Get rid of redundant object lookup
* Pad: Serialize 'stage' state
[SAVEVERSION+]
* Pad: Reduce Freeze duplication and add markers
Catch any possible unhandled device type change.
[SAVEVERSION+]
* Pad: Localize controller type names
* Pad: Handle mismatch between state and current config
* Misc: Drop .at() from vector/array access
We don't use exceptions.
* Pad: Remove redundant GetUnifiedSlot()
Sio has routines for converting these.
* Sio2: Remove redundant optional in Pad()
* Pad: Constify and finalize controller classes
* Pad: Move PadManager to Pad namespace
No point having a class when there's only a single instance.
* Pad: Move PadConfig to Pad namespace
* Pad: Move PadMacros to Pad namespace
* Pad: Re-localize controller bindings/settings
* Pad: Make controller info local
Don't want to create duplicates.
* Pad: Use span for ControllerInfo settings/bindings
* Pad: Fix auto-toggled macro buttons
* Pad: Fix pressure for macros
* Pad: Merge PadConfig/PadManager/PadMacros
Faster compile time.
* Pad: Fix incorrect condition in Sio0::SetTxData()
* Pad: Add deadzone for macro triggers
Force pushed because git hates me
[SAVEVERSION+] Bump savestate version
CI: Update locations of pad/memcard sources
Discard leftover old PAD code
Fix additional merge oddities
Add translations for OSD messages
Copyright headers
Version bump
Fix a whole boatload of concurrency problems from file moves and other miscellaneous update problems
Partial redo of PS1 pad support
Fix incorrect mode due to analog behavior at startup
Mostly reimplement SIO0 memory card logic
Still needs pocketstation
Use new runtime wrapped translate function
Dead code
Fix multiple port/slot/presence issues for PS1
Save State version bump
Clean up some duplicate/unused headers
More header consistency
Remove old stray files
Fix incorrect return
Fix uninitialized array
Add missing overrides
Switch to init/close model used by other subsystems
Remove old input recording references
Rename SIO globals
Rename SIO2 FIFO globals
Remove commented SIO0 code for illegal write
Add guitar icon
