Emulation/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-06-15 18:47:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

docs/DSP: Fix typo with MULCMVZ and MULCMV

Browse source
This commit is contained in:
Pokechu22 2021-08-17 20:56:03 -07:00
parent c51c339424
commit 602163b623
3 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Source/Core/Core/DSP/Interpreter/DSPIntMultiplier.cpp
View file

@ -372,7 +372,6 @@ void Interpreter::mulcac(const UDSPInstruction opc)
// Multiply mid part of accumulator register $acS.m by high part $axT.h of
// secondary accumulator $axT (treat them both as signed). Move product
// register before multiplication to accumulator $acR.
// possible mistake in duddie's doc axT.h rather than axS.h
//
// flags out: --xx xx0x
void Interpreter::mulcmv(const UDSPInstruction opc)
@ -395,7 +394,6 @@ void Interpreter::mulcmv(const UDSPInstruction opc)
// MULCMVZ $acS.m, $axT.h, $acR
// 110s t01r xxxx xxxx
// (fixed possible bug in duddie's description, s->t)
// Multiply mid part of accumulator register $acS.m by high part $axT.h of
// secondary accumulator $axT (treat them both as signed). Move product
// register before multiplication to accumulator $acR, set (round) low part of

2
Source/Core/Core/DSP/Jit/x64/DSPJitMultiplier.cpp
View file

@ -586,7 +586,6 @@ void DSPEmitter::mulcac(const UDSPInstruction opc)
// Multiply mid part of accumulator register $acS.m by high part $axT.h of
// secondary accumulator $axT (treat them both as signed). Move product
// register before multiplication to accumulator $acR.
// possible mistake in duddie's doc axT.h rather than axS.h
// flags out: --xx xx0x
void DSPEmitter::mulcmv(const UDSPInstruction opc)
@ -618,7 +617,6 @@ void DSPEmitter::mulcmv(const UDSPInstruction opc)
// MULCMVZ $acS.m, $axT.h, $acR
// 110s t01r xxxx xxxx
// (fixed possible bug in duddie's description, s->t)
// Multiply mid part of accumulator register $acS.m by high part $axT.h of
// secondary accumulator $axT (treat them both as signed). Move product
// register before multiplication to accumulator $acR, set (round) low part of

12
docs/DSP/GameCube_DSP_Users_Manual/GameCube_DSP_Users_Manual.tex
View file

@ -3279,14 +3279,14 @@ A ``-'' indicates that the flag retains its previous value, a ``0'' indicates th
\end{DSPOpcodeFormat}
\begin{DSPOpcodeDescription}
\item Multiply mid part of accumulator register \Register{\$acS.m} by high part \Register{\$axS.h} of
secondary accumulator \Register{\$axS} (treat them both as signed).
\item Multiply mid part of accumulator register \Register{\$acS.m} by high part \Register{\$axT.h} of
secondary accumulator \Register{\$axT} (treat them both as signed).
Move product register before multiplication to accumulator \Register{\$acR}.
\end{DSPOpcodeDescription}
\begin{DSPOpcodeOperation}
temp = $prod
$prod = $acS.m * $axS.h
$prod = $acS.m * $axT.h
$acR = temp
$pc++
\end{DSPOpcodeOperation}
@ -3308,15 +3308,15 @@ A ``-'' indicates that the flag retains its previous value, a ``0'' indicates th
\end{DSPOpcodeFormat}
\begin{DSPOpcodeDescription}
\item Multiply mid part of accumulator register \Register{\$acS.m} by high part \Register{\$axS.h} of
secondary accumulator \Register{\$axS} (treat them both as signed).
\item Multiply mid part of accumulator register \Register{\$acS.m} by high part \Register{\$aTS.h} of
secondary accumulator \Register{\$axT} (treat them both as signed).
Move product register before multiplication to accumulator \Register{\$acR}.
Set low part of accumulator \Register{\$acR.l} to zero.
\end{DSPOpcodeDescription}
\begin{DSPOpcodeOperation}
temp = $prod
$prod = $acS.m * $axS.h
$prod = $acS.m * $axT.h
$acR.hm = temp.hm
$acR.l = 0
$pc++