Commit graph

64 commits

Author SHA1 Message Date
Pedro Montes Alcalde
4a14d546ba
Tick Tick Tick, thats the sound of 2024 flying by (#3503) 2025-01-19 18:51:43 -03:00
bookmist
a0b3218466 modules/SceNgs: fix crash of Helldivers game 2024-05-22 22:51:24 +03:00
bookmist
1fda880a94 vita3k: big code cleanup
Improvements
* lang: a bit more verbose error on wrong lang xml

Bugfixes
* kernel/sync_primitives: fix theoretically possible AV
* modules/SceAudio: a bit more correct sceAudioOutSetConfig
* fix wrong objects initialisation ({0} -> {})

Warning fixes
* clang warning: Macro argument should be enclosed in parentheses
[bugprone-macro-parentheses]
* modules: set unsigned type for Sce*ErrorCode enums
* clang warning: variable might be not be initialized
* clang warning: Function returns by const value. Consider returning by non-const value instead.
* clang warning: Prefer transparent functors [modernize-use-transparent-functors]

Refactoring
* io/device: move functions implementation from .h to .cpp file
* vita3k: fix fs::path usage
* clang warning: 'if' statement is unnecessary; deleting null pointer has no effect
* vita3k: use structured bindings and references in for-each-loops
* vita3k: simplify container operations, extract frequent operations to utility functions
* clang⚠️ 'contains' member function can be used
* kernel/sync_primitives: refactoring. drop unused parameter of handle_timeout
* vita3k: drop unused function parameters

* vita3k: fix typecasts
use static_cast instead of reinterpret casts if possible
use correct constants (1/1.0/1.0f)
correct variable types to minimise typecasts
use explicit typecasts (not everywhere)
replace c-style typecasts to c++ style typecasts (not everywhere)
* clang warning: remove redundant typecasts
* clang warning: Cast drops const qualifier

Optimisation
* vita3k: remove unused includes
* clang warning: Constness of returning variable prevents automatic move
[performance-no-automatic-move]
* clang warning: String concatenation results in allocation of unnecessary temporary strings
[performance-inefficient-string-concatenation]
* vita3k: use std::move
* vita3k: optimization. push_back -> emplace_back
* vita3k: fix datatypes to avoid unnesessary conversions
* clang warning: remove unneeded string->c_str->string conversion
* clang warning: The parameter is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
* clang warning: 'find' called with a string literal consisting of a single character
[performance-faster-string-find]
* clang warning: Result of a postfix operator is discarded, consider replacing it with a prefix operator
* clang warning: Pass value parameters by const reference

Code cleanup
* io/io: remove once used variables
* net/posixsocket: remove struct keyword
* vita3k: use raw string literals to avoid excessive escaping
* vita3k: refactoring. replace Ptr<> to pointer in Sce functions
* vita3k: drop unused variables and incorrect comments
* clang warning: readability-inconsistent-declaration-parameter-name
* clang warning: Extra ';' after member function definition
* clang warning: Possible misuse of comma operator (, is used instead of ;)
* clang warning: Algorithm accepting an iterator and a count can be used
* clang warning: Declaration and assignment can be joined
* clang warning: Type trait can be simplified using a template alias or a variable template

* vita3k: cleanup class methods
remove unimplemented (and obviously not used) methods
move deleted methods to public
change empty body to =default
remove auto constructors
set member default values
2024-03-18 15:44:56 +03:00
Pedro Montes Alcalde
34565e3ef4
Vita2024K: Happy 2024 2024-01-01 12:36:32 -03:00
Macdu
7d542171c7
modules/SceNgs: Improve sceNgsAT9GetSectionDetails (#3150) 2023-12-31 10:31:48 +01:00
Macdu
770fb206dd ngs: Improve player/atrac9 transition 2023-11-27 12:59:55 +01:00
Macdu
6f35f1a3ab vita3k: Use LOG_..._ONCE when appropriate 2023-10-10 16:31:47 +02:00
Macdu
47d29bdce9 ngs: Improve support for mono voices 2023-10-09 22:25:16 +02:00
bookmist
810c3aeacd ngs: return error and workaround crashes on invalid configurations
util/log: LOG_*_ONCE macros
modules/SceNgs: implement sceNgsVoiceGetModuleType
modules/SceNgs: return error on incomplete output paths and null voice definition
ngs/modules/player: workaround crash if required playback frequency is invalid
2023-09-23 23:31:16 +03:00
Macdu
e64fa370c7 modules: cleanup 2023-09-10 23:35:12 +02:00
slipcounter
87ca930ec9 modules/SceNgsUser: Fix crash in sceNgsVoiceSetParamsBlock 2023-07-20 16:41:31 +02:00
Macdu
82dabe806a ngs: Stub all audio modules 2023-06-20 11:42:34 +02:00
Macdu
745292f606 ngs: Big refractor 2023-06-20 11:42:34 +02:00
Macdu
497c8df9c5 modules/SceNgs: Cleanup 2023-06-20 11:42:34 +02:00
Macdu
b946a8834e modules/SceNgs: Do not return error for sceNgsVoiceGetStateData if mem is null 2023-04-23 12:54:56 +02:00
EXtremeExploit
41a17e79c7 Planet Earth Season 2023 2023-01-02 10:46:20 +01:00
bookmist
8edd333400 Fix compiler warnings 2022-11-16 21:39:55 +03:00
bookmist
f03c257a33 modules: Add Tracy to all implemented functions in implemented modules.
modules/tracy: module name macro
Remove unused hack from SceMp4, mark ScePgf/sceFontNewLib unimplemented
2022-10-29 20:35:17 +03:00
Pedro Montes Alcalde
1ce445ce60
ngs: Add a missing nullptr check on sceNgsVoiceGetStateData 2022-10-06 09:55:16 -03:00
Macdu
2eefc9751e vita3k: Remove unnecessary dependencies between librairies and files 2022-07-28 12:24:06 +02:00
Pedro Montes Alcalde
ee04697b4e
gui/cfg: Invert NGS option to make clearer for user (#1975) 2022-07-25 18:56:58 -03:00
hobyst
1169da50bc host: Rename host to emuenv
This commit renames the host library as emuenv (emulated PS Vita
environment) to avoid confusion with the future host OS abstraction
layer
2022-07-03 14:31:24 +02:00
Macdu
ba95261acb ngs: Implement playback rate in the Atrac9 player 2022-06-04 20:08:37 +02:00
Zangetsu38
b066a1a09e modules/SceNgs: Add missing check for voice and ngs disable option.
- fix crash when Ngs is disable.
2022-06-03 14:03:12 +02:00
Macdu
0e0a3c3982 modules/SceNgsUser: Implement release functions 2022-06-02 20:50:01 +02:00
Macdu
14cc5604b8 ngs: Fix player modules behavior 2022-05-24 16:59:22 +02:00
Macdu
d1dfdd7b1c ngs: Better handling of voice state 2022-05-24 16:59:22 +02:00
Macdu
1658c62e31 ngs: Fix parse_params and add missing checks 2022-05-21 14:28:33 +02:00
Macdu
b0cbdea184 ngs: Implement new functions 2022-05-20 19:39:46 +02:00
Macdu
b289ad9056 ngs: Fix softlock happening when calling update 2022-05-19 00:58:17 +02:00
Macdu
71df446f34 ngs: Fix VoiceState and sceNgsVoiceKeyOff 2022-05-18 23:18:25 +02:00
bookmist
795fe5bbca modules/SceNgsUser: add null check to function sceNgsAT9GetSectionDetails 2022-05-02 17:39:27 +02:00
bookmist
d06e542493 ngs/sheduler: fix deadlock when voice stop or pause inside voice callback. 2022-05-02 12:45:12 +02:00
Zangetsu38
8ef82f0487 modules/SceNgs: implement sceNgsVoiceSetParamsBlock.
- fix some wrong value/struct set.

Co-authored-by: pent0 <fewdspuckrito@gmail.com>
2021-11-20 14:37:23 +01:00
hobyst
168dfb19ca Add license notice on source files which didn't have one
- Also updated the copyright notice year on all files to 2021
2021-08-19 23:14:27 +02:00
sunho
7ba6d2d9af mem: Allow Ptr = nullptr 2021-05-27 04:04:17 +02:00
Zangetsu38
7ff9b205e5 SceNgs: fix crash if it is disable. 2021-05-09 16:07:22 +02:00
Zangetsu38
f2da083abd ngs/sheduler: fix some sound playing. 2021-04-14 16:47:23 +02:00
Zangetsu38
8eb422ba73 gui/settings dialog: Add custom config by apps. 2021-04-08 16:32:38 +02:00
Zangetsu38
8bcd651b37 modules/SceNgs: implement VoiceKeyOff. 2021-04-01 16:40:53 +02:00
Zangetsu38
058ab3c5a5 modules/SceNgs: Implement VoicePatchSetVolume/s. 2021-03-29 14:18:22 +07:00
mangren
fcd0d1cfd6 modules/SceNgs: Implement sceNgsPatchGetInfo. 2021-03-16 16:22:59 +01:00
mangren
aab11d44a3 modules/SceNgs: Implement sceNgsVoiceGetOutputPatch. 2021-03-16 16:22:59 +01:00
Zangetsu38
ab84ef51d0 modules/SceNgs: Implement sceNgsVoicePatchSetVolumesMatrix. 2021-03-16 16:22:59 +01:00
mangren
d00e299b8f Modules/sceNgs: Implement resume/pause 2021-03-16 16:22:59 +01:00
mangren
845a608e38 ngs: refactor, implement callbacks and getinfo.
modules/SceNgs: Implement sceNgsVoiceGetInfo.
A voice and its definition can now specify multiple modules processing, each one will has its own storage for voice state, parameters and callbacks
ngs: Implement callback for atrac9 module
ngs: Stub simple voice and atrac9 simple voices
ngs/atrac9: Renew decoder state when config data change
ngs: allow complex voice definition stubbing
2021-03-16 16:22:59 +01:00
sunho
122b594a99 ngs: add gui option to disable it 2020-09-08 19:20:02 +09:00
sunho
34188dcb6b ngs: fix minor index error 2020-08-15 23:04:15 +02:00
1whatleytay
0beecf723d ngs: run clang-format 2020-07-08 14:33:08 -04:00
1whatleytay
c2a3b292c6 ngs: make "passthrough" module default 2020-07-08 14:11:51 -04:00