Commit graph

27 commits

Author SHA1 Message Date
Pedro Montes Alcalde
4a14d546ba
Tick Tick Tick, thats the sound of 2024 flying by (#3503) 2025-01-19 18:51:43 -03:00
bookmist
1fda880a94 vita3k: big code cleanup
Improvements
* lang: a bit more verbose error on wrong lang xml

Bugfixes
* kernel/sync_primitives: fix theoretically possible AV
* modules/SceAudio: a bit more correct sceAudioOutSetConfig
* fix wrong objects initialisation ({0} -> {})

Warning fixes
* clang warning: Macro argument should be enclosed in parentheses
[bugprone-macro-parentheses]
* modules: set unsigned type for Sce*ErrorCode enums
* clang warning: variable might be not be initialized
* clang warning: Function returns by const value. Consider returning by non-const value instead.
* clang warning: Prefer transparent functors [modernize-use-transparent-functors]

Refactoring
* io/device: move functions implementation from .h to .cpp file
* vita3k: fix fs::path usage
* clang warning: 'if' statement is unnecessary; deleting null pointer has no effect
* vita3k: use structured bindings and references in for-each-loops
* vita3k: simplify container operations, extract frequent operations to utility functions
* clang⚠️ 'contains' member function can be used
* kernel/sync_primitives: refactoring. drop unused parameter of handle_timeout
* vita3k: drop unused function parameters

* vita3k: fix typecasts
use static_cast instead of reinterpret casts if possible
use correct constants (1/1.0/1.0f)
correct variable types to minimise typecasts
use explicit typecasts (not everywhere)
replace c-style typecasts to c++ style typecasts (not everywhere)
* clang warning: remove redundant typecasts
* clang warning: Cast drops const qualifier

Optimisation
* vita3k: remove unused includes
* clang warning: Constness of returning variable prevents automatic move
[performance-no-automatic-move]
* clang warning: String concatenation results in allocation of unnecessary temporary strings
[performance-inefficient-string-concatenation]
* vita3k: use std::move
* vita3k: optimization. push_back -> emplace_back
* vita3k: fix datatypes to avoid unnesessary conversions
* clang warning: remove unneeded string->c_str->string conversion
* clang warning: The parameter is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
* clang warning: 'find' called with a string literal consisting of a single character
[performance-faster-string-find]
* clang warning: Result of a postfix operator is discarded, consider replacing it with a prefix operator
* clang warning: Pass value parameters by const reference

Code cleanup
* io/io: remove once used variables
* net/posixsocket: remove struct keyword
* vita3k: use raw string literals to avoid excessive escaping
* vita3k: refactoring. replace Ptr<> to pointer in Sce functions
* vita3k: drop unused variables and incorrect comments
* clang warning: readability-inconsistent-declaration-parameter-name
* clang warning: Extra ';' after member function definition
* clang warning: Possible misuse of comma operator (, is used instead of ;)
* clang warning: Algorithm accepting an iterator and a count can be used
* clang warning: Declaration and assignment can be joined
* clang warning: Type trait can be simplified using a template alias or a variable template

* vita3k: cleanup class methods
remove unimplemented (and obviously not used) methods
move deleted methods to public
change empty body to =default
remove auto constructors
set member default values
2024-03-18 15:44:56 +03:00
Pedro Montes Alcalde
34565e3ef4
Vita2024K: Happy 2024 2024-01-01 12:36:32 -03:00
Zangetsu38
eb521c25dd gui & modules/save data dialog: Some fix and reworks.
- fix some crash on fixed mode with reworks navigate in button and set first switch of display mode.
- fix icon missing in fixed mode for slot > 0 with reworks load icon texture.
- fix clean preview info in SaveDataDialogInit with reset savedata struct.
- fix dialog show one save of system data with this reset of struct.
- Improve position of new save data in fixed and list mode.
- disable common dialog when app is paused.
- remove duplicate code of open save slot with set all inside check save file and reworks it.
2023-06-27 21:59:03 +02:00
Zangetsu38
03a8c30175 modules/SceCommonDialog: Fix allocate EmptyParam for slot upper 0.
- Empty param is not only in slot 0, is for all slot available, so move on vector.
- Should fix all missing new save icon.
gui/common dialog/save dialog: fix position of text in new save.
- Fix pos and the size of the elements regardless of the size of the window.
- Fix scroll bar missing.
2023-06-23 22:07:05 +02:00
EXtremeExploit
41a17e79c7 Planet Earth Season 2023 2023-01-02 10:46:20 +01:00
Macdu
2eefc9751e vita3k: Remove unnecessary dependencies between librairies and files 2022-07-28 12:24:06 +02:00
hobyst
1169da50bc host: Rename host to emuenv
This commit renames the host library as emuenv (emulated PS Vita
environment) to avoid confusion with the future host OS abstraction
layer
2022-07-03 14:31:24 +02:00
Macdu
5cb80b2400 modles/SceCommonDialog,SceIme: Improve errors and stubbed implementation 2022-07-02 00:20:29 +02:00
Pedro Montes Alcalde
e8151664b7
cmake: Treat format-secutiry warnings as errors (#1667) 2022-06-12 01:03:43 -03:00
Zangetsu38
28c9acd5e5 modules/SceCommonDialog: Add system msg type NOSPACE CONTINUABLE.
- Request by minecraft.
2022-05-19 18:40:02 +02:00
Zangetsu38
f5073260ed lang: complete refactor. 2022-02-20 23:06:57 +01:00
Zangetsu38
a630171274 modules/SceAppUtil: Implement sceAppUtilSaveDataSlotSearch. 2022-01-13 05:51:55 +01:00
Zangetsu38
673874ce5b modules/SceCommonDialog: fix savedata dialog when emptyparam is null.
- refactor check_empty_param for no have double code.
- app util: clean double value.
- modules/(SceAppUtil/SceAppMgrUser): set good value name.
2021-12-28 23:29:34 +01:00
Zangetsu38
96c7773a77 ime dialog: fix button when title is empty with small refactor.
- should fix some game with this issue on button no responding.
2021-10-13 20:41:44 +02:00
hobyst
168dfb19ca Add license notice on source files which didn't have one
- Also updated the copyright notice year on all files to 2021
2021-08-19 23:14:27 +02:00
Zangetsu38
d367be7368 gui/lang: add some common text. 2021-04-02 08:45:31 +02:00
Zangetsu38
ce683e01c0 common dialog: add lang support for (trophy/save data) dialog 2021-03-16 12:31:28 +01:00
IllusionMan1212
e640630a6e gui/SceCommonDialog: implement info window, use firmware font, fix buttons on progress bar mode 2020-09-04 09:32:17 +03:00
IllusionMan1212
0ce103087d gui/SceCommonDialog: implement some missing msg modes and redesign msg dialog 2020-09-04 09:32:17 +03:00
IllusionMan1212
d85ec0cd1a SceCommonDialog/SceAppUtil/io: various save fixes
* io: create parent directories of saves if they don't exist
* sceapputil: fix creating slotparam files
* scecommondialog: fix progress bar and add checks
2020-08-31 03:51:21 +09:00
IllusionMan1212
5c019a0886 SceCommonDialog: implement system message mode for savedata dialog and add checks 2020-06-22 09:07:51 +02:00
IllusionMan1212
8fb3c96e10 SceCommonDialog: implement savedatadialog substatus and fix other bugs 2020-06-08 15:41:22 +02:00
totlmstr
4e20885f89 Vita3K: run clang-format 2020-04-07 16:48:08 -04:00
1whatleytay
34a02553c4
vita3k: remove vita-headers (#649) 2020-02-06 09:44:49 -05:00
IllusionMan1212
0c8872059e modules/gui: implemented sceSaveDataDialog 2020-01-15 00:40:19 +02:00
Nicolas Jallamion
06299de242 emulator: Refactor file structure (#557)
Also:
- external: update some submodules.
2019-08-28 16:52:07 +03:00