Emulation/StrikeBox
1
0
Fork 0
mirror of https://github.com/StrikerX3/StrikeBox.git synced 2024-06-23 14:53:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use std::forward and rvalue references to simplify SharedMemory.Allocate invocations with reference arguments

Browse source
This commit is contained in:
StrikerX3 2019-01-17 22:38:50 -02:00
parent 3bf2988b34
commit 068dcfce27
9 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/common/vixen/shared_memory.h
View file

@ -35,7 +35,7 @@ public:
* otherwise the existing memory block is reused.
*/
template<class T, typename... Args>
T* Allocate(Args... args) {
T* Allocate(Args&&... args) {
// Invoke destructor from previous data structure
if (m_dtor != nullptr) {
m_dtor(*this);
@ -52,7 +52,7 @@ public:
// Update destructor to new data structure and call constructor
m_dtor = [](SharedMemory& u) { ((T*)u.m_memory)->~T(); };
return new(m_memory) T(args...);
return new(m_memory) T(std::forward<Args>(args)...);
}
/*!

2
src/core/vixen/hw/ata/cmds/cmd_identify_device.h
View file

@ -28,7 +28,7 @@ public:
IdentifyDevice(ATADevice& device);
virtual ~IdentifyDevice() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<IdentifyDevice, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<IdentifyDevice>(device); }
protected:
bool HasMoreData() override;

2
src/core/vixen/hw/ata/cmds/cmd_identify_packet_device.h
View file

@ -28,7 +28,7 @@ public:
IdentifyPacketDevice(ATADevice& device);
virtual ~IdentifyPacketDevice() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<IdentifyPacketDevice, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<IdentifyPacketDevice>(device); }
protected:
bool HasMoreData() override;

2
src/core/vixen/hw/ata/cmds/cmd_init_dev_params.h
View file

@ -28,7 +28,7 @@ public:
InitializeDeviceParameters(ATADevice& device);
virtual ~InitializeDeviceParameters() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<InitializeDeviceParameters, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<InitializeDeviceParameters>(device); }
protected:
bool ExecuteImpl() override;

2
src/core/vixen/hw/ata/cmds/cmd_packet.h
View file

@ -28,7 +28,7 @@ public:
Packet(ATADevice& device);
virtual ~Packet() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<Packet, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<Packet>(device); }
};
}

2
src/core/vixen/hw/ata/cmds/cmd_read_dma.h
View file

@ -28,7 +28,7 @@ public:
ReadDMA(ATADevice& device);
virtual ~ReadDMA() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<ReadDMA, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<ReadDMA>(device); }
};
}

2
src/core/vixen/hw/ata/cmds/cmd_security_unlock.h
View file

@ -28,7 +28,7 @@ public:
SecurityUnlock(ATADevice& device);
virtual ~SecurityUnlock() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<SecurityUnlock, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<SecurityUnlock>(device); }
protected:
bool Initialize() override;

2
src/core/vixen/hw/ata/cmds/cmd_set_features.h
View file

@ -28,7 +28,7 @@ public:
SetFeatures(ATADevice& device);
virtual ~SetFeatures() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<SetFeatures, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<SetFeatures>(device); }
protected:
bool ExecuteImpl() override;

2
src/core/vixen/hw/ata/cmds/cmd_write_dma.h
View file

@ -28,7 +28,7 @@ public:
WriteDMA(ATADevice& device);
virtual ~WriteDMA() override;
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<WriteDMA, ATADevice&>(device); }
static IATACommand *Factory(SharedMemory& sharedMemory, ATADevice& device) { return sharedMemory.Allocate<WriteDMA>(device); }
};
}