Emulation/RetroArch
1
0
Fork 0
mirror of https://github.com/libretro/RetroArch.git synced 2025-04-02 10:51:52 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix ISO scan crash from buffer overflow

Browse source 
Recent additions in commit #bbb2a7d6f to scan ISO files with ASCII characters overflowed the serial number buffer and caused a crash. This fix limits the read to 15 bytes which is all that is actually required.
This commit is contained in:
Aaron Oneal 2017-09-06 23:37:46 -07:00
parent 0bda66cc2e
commit e3f4e0d71a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tasks/task_database_cue.c
View file

@ -350,7 +350,8 @@ int detect_serial_ascii_game(const char *track_path, char *game_id)
for (pos = 0; pos < 10000; pos++)
{
filestream_seek(fd, pos, SEEK_SET);
if (filestream_read(fd, game_id, 10000) > 0)
/* Current logic only requires 15 characters (max of 4096 per sizeof game_id). */
if (filestream_read(fd, game_id, 15) > 0)
{
unsigned i;
game_id[15] = '\0';