From d4d678838128db591ededa01ced440eb9bd66e2f Mon Sep 17 00:00:00 2001 From: twinaphex Date: Tue, 26 Jan 2016 04:58:40 +0100 Subject: [PATCH] Use sizeof(variable) instead of hardcoded PATH_MAX_LENGTH --- menu/menu_displaylist.c | 8 ++++---- tasks/task_database_cue.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/menu/menu_displaylist.c b/menu/menu_displaylist.c index 2bbc53f6e5..6c102a0944 100644 --- a/menu/menu_displaylist.c +++ b/menu/menu_displaylist.c @@ -336,7 +336,7 @@ static int menu_displaylist_parse_debug_info(menu_displaylist_info_t *info) MENU_SETTINGS_CORE_INFO_NONE, 0, 0); /* Try to create a "test" subdirectory on top of libretro directory */ - fill_pathname_join(tmp, settings->libretro_directory, ".retroarch", PATH_MAX_LENGTH); + fill_pathname_join(tmp, settings->libretro_directory, ".retroarch", sizeof(tmp)); ret = path_mkdir(tmp); snprintf(tmp, sizeof(tmp), "- create a directory... %s", ret ? "passed" : "failed"); menu_entries_push(info->list, tmp, "", @@ -357,7 +357,7 @@ static int menu_displaylist_parse_debug_info(menu_displaylist_info_t *info) MENU_SETTINGS_CORE_INFO_NONE, 0, 0); /* Check if save directory is writable */ - fill_pathname_join(tmp, global->dir.savefile, ".retroarch", PATH_MAX_LENGTH); + fill_pathname_join(tmp, global->dir.savefile, ".retroarch", sizeof(tmp)); ret = path_mkdir(tmp); snprintf(tmp, sizeof(tmp), "- directory writable: %s", ret ? "true" : "false"); menu_entries_push(info->list, tmp, "", @@ -378,7 +378,7 @@ static int menu_displaylist_parse_debug_info(menu_displaylist_info_t *info) MENU_SETTINGS_CORE_INFO_NONE, 0, 0); /* Check if save directory is writable */ - fill_pathname_join(tmp, global->dir.savestate, ".retroarch", PATH_MAX_LENGTH); + fill_pathname_join(tmp, global->dir.savestate, ".retroarch", sizeof(tmp)); ret = path_mkdir(tmp); snprintf(tmp, sizeof(tmp), "- directory writable: %s", ret ? "true" : "false"); menu_entries_push(info->list, tmp, "", @@ -399,7 +399,7 @@ static int menu_displaylist_parse_debug_info(menu_displaylist_info_t *info) MENU_SETTINGS_CORE_INFO_NONE, 0, 0); /* Check if save directory is writable */ - fill_pathname_join(tmp, settings->system_directory, ".retroarch", PATH_MAX_LENGTH); + fill_pathname_join(tmp, settings->system_directory, ".retroarch", sizeof(tmp)); ret = path_mkdir(tmp); snprintf(tmp, sizeof(tmp), "- directory writable: %s", ret ? "true" : "false"); menu_entries_push(info->list, tmp, "", diff --git a/tasks/task_database_cue.c b/tasks/task_database_cue.c index a278c8ede2..3324de197e 100644 --- a/tasks/task_database_cue.c +++ b/tasks/task_database_cue.c @@ -351,7 +351,7 @@ int find_first_data_track(const char *cue_path, char cue_dir[PATH_MAX_LENGTH]; RFILE *fd; - strlcpy(cue_dir, cue_path, PATH_MAX_LENGTH); + strlcpy(cue_dir, cue_path, sizeof(cue_dir)); path_basedir(cue_dir); fd = retro_fopen(cue_path, RFILE_MODE_READ, -1);