Recent reports of specific configurations or versions changing some of the event handling order, resulting in the screensaver video/audio not stopping when a game is launched from it.
Can't replicate on my end, but these changes should be harmless for the current setup, and should help with that scenario. To be fair, it should have been there from the get go - it's just pure luck that things worked until now, as the screensaver was being halted before this code would run.
commit 5d07dac51f0ac77cb3771dc2a7c69677b882de00
Author: Gemba <uid0@sdf-eu.org>
Date: Wed Mar 22 01:04:40 2023 +0100
re-enable wrapping when fixed >0 y-size value of TextComponent is given
commit 47fc0c9edb95b08fccde01fd1778e3789f6e617a
Merge: 7f3bc53 5a3b907
Author: Gemba <uid0@sdf-eu.org>
Date: Wed Mar 1 07:36:05 2023 +0100
Merge branch 'master' of https://github.com/Gemba/EmulationStation into fix_short_desc_wordwrap
commit 5a3b9074e1
Merge: 34b25450057745
Author: pjft <pjft@users.noreply.github.com>
Date: Mon Feb 27 20:01:05 2023 +0000
Merge pull request #801 from Gemba/fix_ui_transition_style_slide_gamelistview_rollover
UI Slide Mode: Changes to allow rollover left/right at gamelist-view edges
commit 00577453d2
Author: Gemba <uid0@sdf-eu.org>
Date: Mon Feb 27 20:46:58 2023 +0100
Squashed commit of the following:
commit 895e176c513ca1556c60c5c29c85bd43da3675e0
Author: Gemba <uid0@sdf-eu.org>
Date: Fri Aug 5 13:37:44 2022 +0200
Changes to allow rollover at gamelist edges instead of rolling back in 'slide' mode.
Needs 'Transition Style' set to 'slide'.
Needs 'Quick Navigation' in Gamelist view enabled.
commit 7f3bc5345577f6d0d6625bec6a40fa2468e0395d
Merge: be99449 b88f5ac
Author: Gemba <uid0@sdf-eu.org>
Date: Sat Feb 18 16:11:23 2023 +0100
Merge branch 'fix_short_desc_wordwrap' of https://github.com/Gemba/EmulationStation into fix_short_desc_wordwrap
commit b88f5acbc03955aa251cb87445bce1437a4abf06
Merge: 1eb0147 34b2545
Author: Gemba <Gemba@users.noreply.github.com>
Date: Sat Feb 18 12:58:46 2023 +0100
Merge branch 'RetroPie:master' into fix_short_desc_wordwrap
commit 1eb0147e24573e761f5a65ce7f46e2b055cb124c
Merge: 07002d6 0c4b42d
Author: Gemba <Gemba@users.noreply.github.com>
Date: Sun Sep 25 14:31:36 2022 +0200
Merge branch 'RetroPie:master' into fix_short_desc_wordwrap
commit 07002d61d5a1722588c2b34bee6783c01a7a9c18
Author: Gemba <uid0@sdf-eu.org>
Date: Sat Aug 13 18:37:11 2022 +0200
Make short descriptions wrap to next line instead of adding ellipsis.
The ellipsis effect instead of wrapping to a new line had two causes:
1. A short description ends slightly after the x-bounding value of the textcomponent (can happen in any theme).
2. Themes with a linespacing with less than 1.2 (120% of highest character) get a wrong flag set for detecting if it is a multi line text. Carbon uses 1.5 linespacing by default thus this case never to carbon.
Fixes:
1. An additional clause in Font.cpp::wrapText() was added to fix this effect and to force wrapping instead of adding ellipsis.
2. The evaluation of the variable isMultiline in TextComponent::onTextChanged() takes the actual linespacing for calculation instead of the "magic float" of 1.2.
cf. https://retropie.org.uk/forum/topic/32893/very-short-descriptions-don-t-wrap
commit be9944921e47ebfa57acae8200d495f356774c2b
Author: Gemba <uid0@sdf-eu.org>
Date: Sat Aug 13 18:37:11 2022 +0200
Make short descriptions wrap to next line instead of adding ellipsis.
This effect was agnostic to the theme in use. The ellipsis effect was most prevalent on short descriptions, but may also occour whenever the last line of a description shortly ends after the maximum width of the bounding box, overrunning the bounding box by upto two non whitespace characters.
An additional clause in Font.cpp::wrapText() was added to fix this effect and to force wrapping instead of adding ellipsis.
cf. https://retropie.org.uk/forum/topic/32893/very-short-descriptions-don-t-wrap
commit 47fc0c9edb95b08fccde01fd1778e3789f6e617a
Merge: 7f3bc53 5a3b907
Author: Gemba <uid0@sdf-eu.org>
Date: Wed Mar 1 07:36:05 2023 +0100
Merge branch 'master' of https://github.com/Gemba/EmulationStation into fix_short_desc_wordwrap
commit 5a3b9074e1
Merge: 34b25450057745
Author: pjft <pjft@users.noreply.github.com>
Date: Mon Feb 27 20:01:05 2023 +0000
Merge pull request #801 from Gemba/fix_ui_transition_style_slide_gamelistview_rollover
UI Slide Mode: Changes to allow rollover left/right at gamelist-view edges
commit 00577453d2
Author: Gemba <uid0@sdf-eu.org>
Date: Mon Feb 27 20:46:58 2023 +0100
Squashed commit of the following:
commit 895e176c513ca1556c60c5c29c85bd43da3675e0
Author: Gemba <uid0@sdf-eu.org>
Date: Fri Aug 5 13:37:44 2022 +0200
Changes to allow rollover at gamelist edges instead of rolling back in 'slide' mode.
Needs 'Transition Style' set to 'slide'.
Needs 'Quick Navigation' in Gamelist view enabled.
commit 7f3bc5345577f6d0d6625bec6a40fa2468e0395d
Merge: be99449 b88f5ac
Author: Gemba <uid0@sdf-eu.org>
Date: Sat Feb 18 16:11:23 2023 +0100
Merge branch 'fix_short_desc_wordwrap' of https://github.com/Gemba/EmulationStation into fix_short_desc_wordwrap
commit b88f5acbc03955aa251cb87445bce1437a4abf06
Merge: 1eb0147 34b2545
Author: Gemba <Gemba@users.noreply.github.com>
Date: Sat Feb 18 12:58:46 2023 +0100
Merge branch 'RetroPie:master' into fix_short_desc_wordwrap
commit 1eb0147e24573e761f5a65ce7f46e2b055cb124c
Merge: 07002d6 0c4b42d
Author: Gemba <Gemba@users.noreply.github.com>
Date: Sun Sep 25 14:31:36 2022 +0200
Merge branch 'RetroPie:master' into fix_short_desc_wordwrap
commit 07002d61d5a1722588c2b34bee6783c01a7a9c18
Author: Gemba <uid0@sdf-eu.org>
Date: Sat Aug 13 18:37:11 2022 +0200
Make short descriptions wrap to next line instead of adding ellipsis.
The ellipsis effect instead of wrapping to a new line had two causes:
1. A short description ends slightly after the x-bounding value of the textcomponent (can happen in any theme).
2. Themes with a linespacing with less than 1.2 (120% of highest character) get a wrong flag set for detecting if it is a multi line text. Carbon uses 1.5 linespacing by default thus this case never to carbon.
Fixes:
1. An additional clause in Font.cpp::wrapText() was added to fix this effect and to force wrapping instead of adding ellipsis.
2. The evaluation of the variable isMultiline in TextComponent::onTextChanged() takes the actual linespacing for calculation instead of the "magic float" of 1.2.
cf. https://retropie.org.uk/forum/topic/32893/very-short-descriptions-don-t-wrap
commit be9944921e47ebfa57acae8200d495f356774c2b
Author: Gemba <uid0@sdf-eu.org>
Date: Sat Aug 13 18:37:11 2022 +0200
Make short descriptions wrap to next line instead of adding ellipsis.
This effect was agnostic to the theme in use. The ellipsis effect was most prevalent on short descriptions, but may also occour whenever the last line of a description shortly ends after the maximum width of the bounding box, overrunning the bounding box by upto two non whitespace characters.
An additional clause in Font.cpp::wrapText() was added to fix this effect and to force wrapping instead of adding ellipsis.
cf. https://retropie.org.uk/forum/topic/32893/very-short-descriptions-don-t-wrap
commit 895e176c513ca1556c60c5c29c85bd43da3675e0
Author: Gemba <uid0@sdf-eu.org>
Date: Fri Aug 5 13:37:44 2022 +0200
Changes to allow rollover at gamelist edges instead of rolling back in 'slide' mode.
Needs 'Transition Style' set to 'slide'.
Needs 'Quick Navigation' in Gamelist view enabled.
Added some extra info to help RetroPie's auto-configuration scripts by exporting the joystick Vendor and Product IDs, which should help with RetroArch's joypad profile generation.
Since 2.0.14, SDL's joystick name (`SDL_CreateJoystickName`) is a normalized version of the name reported by the OS (culled consecutive spaces, trimming trailing spaces, renaming known joystick names like Xbox/PS). This breaks the input auto-configuration scripts in RetroPie, which generate a config with new name, while the emulators/ports expect to find the OS reported name (e.g. RetroArch - see #3398 [1] for an example).
This issue is affecting especially PC users, which are not using RetroPie's (old) SDL version and who's RetroArch configuration is incomplete.
Using the Vendor/Product ID would help these situations and support the new SDL versions when added to RetroPie.
[1] https://github.com/RetroPie/RetroPie-Setup/issues/3398
The `<inputAction>` node is useless for the temporary input configuration, so remove it.
Normally, because of the previous `reset` call of the parent document, it would be empty, but I've encountered situations when the memory is not cleared and there's (random binary) garbage added to the temporary configuration file. This results in a broken XML file and the auto-configuration scripts in RetroPie will all fail.
Added an extra parameter for the `remove` call, hinting that a refresh of the View is not desired.
This skips any `onFileChanged` event called at the end of `remove`, leaving it to the caller to explicitely call the `onFileChanged` method. The skip decreases the time spent in `remove`.
The sole usage - right now - is during the initial built-in collections creation, when the `recent` collection trimming can take a long time when it has >>50 entries.
Remove thumbnail, video, image and marquee files for a game when the game file is removed. Check for shared assets when deleting the resources, just in case the scraped files are used in another gamelist, for another game.
Modified the build options and source files to enable `omxplayer` for video previews only when the `OMX` option is used.
Updated the build instructions on RPI accordingly and added some notes about the deprecation of the BRCM GPU drivers in RasPI OS 'Bullseye'.
Previously, the `RPI` build option would be used to add both RPI specific audio settings/VRAM limits AND add `omxplayer` support. However, `omxplayer` does not work with the RPI KMS video driver (`vc4-kms-v3d`) or with a 64bit RPI system, due to the lack of OpenMAX (OMX) API support.
The new RasPi OS ('bullseye') has made the KMS driver the default [1] and doesn't offer `omxplayer` anymore (considered deprecated [2]).
Splitting the OMX support from the RPI option allows to set some default values for RPI systems without automatically adding the `omxplayer` bits.
[1] https://www.raspberrypi.com/news/raspberry-pi-os-debian-bullseye/
[2] https://github.com/popcornmix/omxplayer/commit/1f1d0ccd65
