switch-coreboot/src/drivers/ams/as3722rtc.c
Julius Werner 90d0acbe9a as3277: Fix month-off-by-one error for RTC driver
The AS3277 RTC code seems to closely follow the corresponding Linux
driver. Unfortunately, while coreboot (and even other parts of Linux,
like mktime()) directly follows the standard IBM PC RTC time
representation (except for the BCD part), Linux' struct rtc_time decided
to use 0-based (instead of 1-based) months instead.

This patch removes the faulty month offset that was copied into our
driver so that we will generate correct timestamps again.

BRANCH=nyan
BUG=chrome-os-partner:34108
TEST=firmware_EventLog (pre-release version) gets further than before
(and then craps up on unrelated problems with suspend/resume events).

Change-Id: Ica221a8bcfd7c1c6cd7ba382d760b586d511e3a3
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 5b55c3f5bbecc776a71338256b910aecccac1e04
Original-Change-Id: I163fa4778ec534cd9e6f92a6b6dc55e9871a6a82
Original-Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/238122
Original-Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/9723
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
2015-04-17 09:20:54 +02:00

91 lines
2.5 KiB
C

/*
* This file is part of the coreboot project.
*
* Copyright 2014 The Chromium OS Authors. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include <bcd.h>
#include <console/console.h>
#include <device/i2c.h>
#include <rtc.h>
#include <stdint.h>
enum AS3722_RTC_REG
{
AS3722_RTC_CONTROL = 0x60,
AS3722_RTC_SECOND = 0x61,
AS3722_RTC_MINUTE = 0x62,
AS3722_RTC_HOUR = 0x63,
AS3722_RTC_DAY = 0x64,
AS3722_RTC_MONTH = 0x65,
AS3722_RTC_YEAR = 0x66
};
enum {
AS3722_RTC_CONTROL_ON = 0x1 << 2
};
static uint8_t as3722_read(enum AS3722_RTC_REG reg)
{
uint8_t val;
i2c_readb(CONFIG_DRIVERS_AS3722_RTC_BUS,
CONFIG_DRIVERS_AS3722_RTC_ADDR, reg, &val);
return val;
}
static void as3722_write(enum AS3722_RTC_REG reg, uint8_t val)
{
i2c_writeb(CONFIG_DRIVERS_AS3722_RTC_BUS,
CONFIG_DRIVERS_AS3722_RTC_ADDR, reg, val);
}
static void as3722rtc_init(void)
{
static int initialized;
if (initialized)
return;
uint8_t control = as3722_read(AS3722_RTC_CONTROL);
as3722_write(AS3722_RTC_CONTROL, control | AS3722_RTC_CONTROL_ON);
initialized = 1;
}
int rtc_set(const struct rtc_time *time)
{
as3722rtc_init();
as3722_write(AS3722_RTC_SECOND, bin2bcd(time->sec));
as3722_write(AS3722_RTC_MINUTE, bin2bcd(time->min));
as3722_write(AS3722_RTC_HOUR, bin2bcd(time->hour));
as3722_write(AS3722_RTC_DAY, bin2bcd(time->mday));
as3722_write(AS3722_RTC_MONTH, bin2bcd(time->mon));
as3722_write(AS3722_RTC_YEAR, bin2bcd(time->year));
return 0;
}
int rtc_get(struct rtc_time *time)
{
as3722rtc_init();
time->sec = bcd2bin(as3722_read(AS3722_RTC_SECOND) & 0x7f);
time->min = bcd2bin(as3722_read(AS3722_RTC_MINUTE) & 0x7f);
time->hour = bcd2bin(as3722_read(AS3722_RTC_HOUR) & 0x3f);
time->mday = bcd2bin(as3722_read(AS3722_RTC_DAY) & 0x3f);
time->mon = bcd2bin(as3722_read(AS3722_RTC_MONTH) & 0x1f);
time->year = bcd2bin(as3722_read(AS3722_RTC_YEAR) & 0x7f);
return 0;
}