mirror of
https://github.com/fail0verflow/switch-coreboot.git
synced 2025-05-04 01:39:18 -04:00
5e4be332b3
The virtualized developer switch was invented five years ago and has
been used on every vboot system ever since. We shouldn't need to specify
it again and again for every new board. This patch flips the Kconfig
logic around and replaces CONFIG_VIRTUAL_DEV_SWITCH with
CONFIG_PHYSICAL_DEV_SWITCH, so that only a few ancient boards need to
set it and it fits better with CONFIG_PHYSICAL_REC_SWITCH. (Also set the
latter for Lumpy which seems to have been omitted incorrectly, and hide
it from menuconfig since it's a hardware parameter that shouldn't be
configurable.)
Since almost all our developer switches are virtual, it doesn't make
sense for every board to pass a non-existent or non-functional developer
mode switch in the coreboot tables, so let's get rid of that. It's also
dangerously confusing for many boards to define a get_developer_mode()
function that reads an actual pin (often from a debug header) which will
not be honored by coreboot because CONFIG_PHYSICAL_DEV_SWITCH isn't set.
Therefore, this patch removes all those non-functional instances of that
function. In the future, either the board has a physical dev switch and
must define it, or it doesn't and must not.
In a similar sense (and since I'm touching so many board configs
anyway), it's annoying that we have to keep selecting EC_SOFTWARE_SYNC.
Instead, it should just be assumed by default whenever a Chrome EC is
present in the system. This way, it can also still be overridden by
menuconfig.
CQ-DEPEND=CL:459701
Change-Id: I33d6fe4570b6c7e6d120ed43736413ace0016454
Original-Change-Id: If9cbaa7df530580a97f00ef238e3d9a8a86a4a7f
Original-Reviewed-on: https://review.coreboot.org/18980
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Commit-Id: 320edbe2ba
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/462010
67 lines
1.4 KiB
Text
67 lines
1.4 KiB
Text
if BOARD_GOOGLE_CYAN
|
|
|
|
config BOARD_SPECIFIC_OPTIONS
|
|
def_bool y
|
|
select BOARD_ROMSIZE_KB_8192
|
|
select EC_GOOGLE_CHROMEEC
|
|
select EC_GOOGLE_CHROMEEC_MEC
|
|
select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
|
|
select ENABLE_BUILTIN_COM1
|
|
select HAVE_ACPI_TABLES
|
|
select HAVE_OPTION_TABLE
|
|
select MAINBOARD_HAS_CHROMEOS
|
|
select MAINBOARD_HAS_LPC_TPM
|
|
select SOC_INTEL_BRASWELL
|
|
select HAVE_ACPI_RESUME
|
|
select PCIEXP_L1_SUB_STATE
|
|
|
|
config CHROMEOS
|
|
select EC_GOOGLE_CHROMEEC_SWITCHES
|
|
select LID_SWITCH
|
|
select VBOOT_VBNV_CMOS
|
|
|
|
config DISPLAY_SPD_DATA
|
|
bool "Display Memory Serial Presence Detect Data"
|
|
default n
|
|
help
|
|
When enabled displays the memory configuration data.
|
|
|
|
config DYNAMIC_VNN_SUPPORT
|
|
bool "Enables support for Dynamic VNN"
|
|
default n
|
|
|
|
config MAINBOARD_DIR
|
|
string
|
|
default google/cyan
|
|
|
|
config MAINBOARD_PART_NUMBER
|
|
string
|
|
default "Cyan"
|
|
|
|
config MAINBOARD_VENDOR
|
|
string
|
|
default "Google"
|
|
|
|
if !GOP_SUPPORT
|
|
config VGA_BIOS_FILE
|
|
string
|
|
default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin"
|
|
help
|
|
The C0 version of the video bios gets computed from this name
|
|
so that they can both be added. Only the correct one for the
|
|
system will be run.
|
|
|
|
config VGA_BIOS_ID
|
|
string
|
|
default "8086,22b0"
|
|
help
|
|
The VGA_BIOS_ID for the C0 version of the video bios is hardcoded
|
|
in soc/intel/braswell/Makefile.inc as 8086,22b1
|
|
|
|
endif #GOP_SUPPORT
|
|
|
|
config GBB_HWID
|
|
string
|
|
depends on CHROMEOS
|
|
default "CYAN TEST A-A 1829"
|
|
endif # BOARD_GOOGLE_CYAN
|