mirror of
https://github.com/fail0verflow/switch-coreboot.git
synced 2025-05-04 01:39:18 -04:00
3cfacbf196
Many functions in cbfstool need to deal with a memory buffer - both location and
size. Right now it's made by different ways: for ROM image using global variable
(romsize, master_header); and in cbfs-* using return value for size and char**
to return memory location.
This may cause bugs like assuming incorrect return types, ex:
uint32_t file_size = parse(); // which returns "-1" on error
if (file_size <= 0) { ...
And the parse error will never be caught.
We can simplify this by introducing a buffer API, to change
unsigned int do_something(char *input, size_t len, char **output, ...)
into
int do_something(struct buffer *input, struct buffer *output, ...)
The buffer API will be used by further commits.
Change-Id: Iaddaeb109f08be6be84c6728d72c6a043b0e7a9f
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: http://review.coreboot.org/2205
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
|
||
|---|---|---|
| .. | ||
| abuild | ||
| acpi | ||
| amdtools | ||
| cbfstool | ||
| cbmem | ||
| crossgcc | ||
| dtd_parser | ||
| dumpmmcr | ||
| ectool | ||
| genprof | ||
| getpir | ||
| gitconfig | ||
| i915tool | ||
| ifdtool | ||
| inteltool | ||
| k8resdump | ||
| kconfig | ||
| lbtdump | ||
| lint | ||
| mkelfImage | ||
| mptable | ||
| msrtool | ||
| nrv2b | ||
| nvramtool | ||
| optionlist | ||
| resetcf | ||
| romcc | ||
| runfw | ||
| sconfig | ||
| superiotool | ||
| vgabios | ||
| xcompile | ||