mirror of
https://github.com/fail0verflow/switch-coreboot.git
synced 2025-05-04 01:39:18 -04:00
48fe3ab5ef
Calling non-PIC code from PIC code needs an ABI wrapper and we don't provide one. Our trick with function pointers is exceedingly fragile: - it depends on gcc not being clever enough - it forces us to compile all initram source files in one go - parallelizing initram compilation breaks the code - compiling one initram source file at a time breaks the code - enabling higher optimizations breaks the code - enabling -fwhole-program breaks the code - declaring the function pointers const breaks the code - it's an undocumented side effect of gcc which will go away - we need excessively ugly shared function wrappers - the shared function wrappers had more than their fair share of bugs - almost nobody understands the wrappers completely - Segher warns against them: "So why do you think this should work? You're telling it to link PIC to non-PIC. Did you read the manual? It's just not allowed. It cannot ever work." Kill the SHARED wrappers and use a real ABI wrapper. The wrapper code is autogenerated on demand. Any function compiled into stage0 is now shared by default, yet the size and code generation of stage0/1/2 code are unchanged. Initram code size does decrease quite a bit and the difficulty of creating shared functions is now zero. The patch includes extensive documentation about the inner workings of the new wrappers and the reasons why they look like this. Build and boot tested on qemu. Build tested on all targets. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Ron says: Wow. we've need this fix for a long time. Acked-by: Ronald G. Minnich <rminnich@gmail.com> git-svn-id: svn://coreboot.org/repository/coreboot-v3@775 f3766cd6-281f-0410-b1cd-43a5c92072e9 |
||
|---|---|---|
| .. | ||
| arch/x86 | ||
| device | ||
| console.h | ||
| elf.h | ||
| elf_boot.h | ||
| ip_checksum.h | ||
| isa-dma.h | ||
| keyboard.h | ||
| lar.h | ||
| lib.h | ||
| mc146818rtc.h | ||
| post_code.h | ||
| shared.h | ||
| spd.h | ||
| spinlock.h | ||
| string.h | ||
| tables.h | ||
| uart8250.h | ||