Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

UPSTREAM: cpu/x86: Fix misc. remaining issues detected by checkpatch

Browse source 
Fix the following error and warnings detected by checkpatch.pl:

ERROR: trailing statements should be on next line
WARNING: storage class should be at the beginning of the declaration
WARNING: type 'long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order

TEST=Build and run on Galileo Gen2

Change-Id: Ia707c6e3a6b65f12d3b1e60510b4a99bc24ea83d
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: dfc8a560d7
Original-Change-Id: I9cfe42cf1836cfd40ffcf67237c818543f508feb
Original-Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Original-Reviewed-on: https://review.coreboot.org/18845
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/456241
This commit is contained in:
Lee Leahy 2017-03-15 16:47:33 -07:00 • committed by chrome-bot
parent 0310f9e513
commit f00b0f1a7a
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/cpu/x86/lapic/lapic_cpu_init.c
View file

@ -95,7 +95,7 @@ static void copy_secondary_start_to_lowest_1M(void)
(unsigned char *)_secondary_start, code_size);
printk(BIOS_DEBUG, "start_eip=0x%08lx, code_size=0x%08lx\n",
(long unsigned int)AP_SIPI_VECTOR, code_size);
(unsigned long int)AP_SIPI_VECTOR, code_size);
}
static void recover_lowest_1M(void)
@ -408,7 +408,7 @@ void stop_this_cpu(void)
#endif
/* C entry point of secondary cpus */
void asmlinkage secondary_cpu_init(unsigned int index)
asmlinkage void secondary_cpu_init(unsigned int index)
{
atomic_inc(&active_cpus);
@ -490,7 +490,8 @@ static void smm_other_cpus(struct bus *cpu_bus, device_t bsp_cpu)
cpu->path.apic.apic_id);
/* FIXME: endless loop */
while (atomic_read(&active_cpus) != pre_count);
while (atomic_read(&active_cpus) != pre_count)
;
}
}

2
src/cpu/x86/smm/smm_module_handler.c
View file

@ -116,7 +116,7 @@ void *smm_get_save_state(int cpu)
return base;
}
void asmlinkage smm_handler_start(void *arg)
asmlinkage void smm_handler_start(void *arg)
{
const struct smm_module_params *p;
const struct smm_runtime *runtime;