From e2a5efc68aba53e0be063e25ad017f462643bd69 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Wed, 3 Aug 2016 20:07:35 -0700 Subject: [PATCH] UPSTREAM: checkpatch: Add BLOCK_COMMENT_STYLE to ignore list Linux' newest checkpatch.pl flags comments like these: /* This is a concise 2-line comment that explains what the code does in * sufficient detail without wasting too much vertical space. */ do_stuff_that_needs_explaining(); Comments like these have been used in our code base for a long time and I don't think we should disallow them now. Ending the comment on the same line doesn't really hurt readability and wastes less screen real estate (which in turn usually helps overall code comprehension). BUG=None BRANCH=None TEST=None Change-Id: I4d0d7c166c3ecd81a8a0d8a4c5133414c9cb5841 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/16060 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi Reviewed-on: https://chromium-review.googlesource.com/368401 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin --- .checkpatch.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/.checkpatch.conf b/.checkpatch.conf index 4b88745ba2..f7b9b32519 100644 --- a/.checkpatch.conf +++ b/.checkpatch.conf @@ -14,3 +14,4 @@ --ignore PREFER_PACKED --ignore PREFER_PRINTF --ignore SPLIT_STRING +--ignore BLOCK_COMMENT_STYLE