Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

UPSTREAM: libpayload: x86/exec - fix argc/argv value passing

Browse source 
According to coreboots payload API [1] the argc value should be passed
at stack offset 0x10, so we need to push a dummy value to comply to the
API.

[1] https://www.coreboot.org/Payload_API

BUG=none
BRANCH=none
TEST=none

Change-Id: I2acc66d20fcc4e313d1ddbc4a7bc1772548981c5
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Original-Commit-Id: 9fa78c136d
Original-Change-Id: Id20424185a5bf7e4d94de1886a2cece3f3968371
Original-Signed-off-by: Mathias Krause <minipli@googlemail.com>
Original-Reviewed-on: https://review.coreboot.org/18333
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/444814
This commit is contained in:
Mathias Krause 2017-02-11 22:34:46 +01:00 • committed by chrome-bot
parent 3206879edd
commit d808757641
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
payloads/libpayload/arch/x86/exec.S
View file

@ -53,12 +53,17 @@ i386_do_exec:
pushl %ecx
pushl %ebp
/* Push the argc and argv pointers on to the stack */
/* Push argc and argv on to the stack.
*
* We need to put a dummy value inbetween, as argc should be at offset
* 0x10, according to the payload API.
*/
movl 12(%ebp), %esi
movl 16(%ebp), %ecx
pushl %esi
pushl $0
pushl %ecx
/* Move a "magic" number on the stack - the other