Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

UPSTREAM: soc/intel/apollolake: Remove duplication of find_microcode_patch() code

Browse source 
Since get_microcode_info() is aleady searching for the microcode in cbfs,
we can just add a intel_microcode_load_unlocked() call here to update
the microcode. No need to duplicate finding microcode step during
pre_mp_init() function.

BUG=none
BRANCH=none
TEST=none

Change-Id: Id9bb31b2b02dd92dadb76cbd37bf1f5e01b64117
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Original-Commit-Id: 97daf98806
Original-Change-Id: I525cab0ecc7826554f0a1209862e6357d1c7a9a6
Original-Signed-off-by: Barnali Sarkar <barnali.sarkar@intel.com>
Original-Reviewed-on: https://review.coreboot.org/20088
Original-Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Furquan Shaikh <furquan@google.com>
Original-Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/531704
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
This commit is contained in:
Barnali Sarkar 2017-06-07 13:47:51 +05:30 • committed by chrome-bot
parent a267ebfc34
commit d7a8cec061
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/soc/intel/apollolake/cpu.c
View file

@ -118,9 +118,6 @@ static void pre_mp_init(void)
{ {
x86_setup_mtrrs_with_detect(); x86_setup_mtrrs_with_detect();
x86_mtrr_check(); x86_mtrr_check();
/* Make sure BSP is using the microcode from cbfs */
intel_update_microcode_from_cbfs();
} }
/* Find CPU topology */ /* Find CPU topology */
@ -140,6 +137,9 @@ static void get_microcode_info(const void **microcode, int *parallel)
{ {
*microcode = intel_microcode_find(); *microcode = intel_microcode_find();
*parallel = 1; *parallel = 1;
/* Make sure BSP is using the microcode from cbfs */
intel_microcode_load_unlocked(*microcode);
} }
static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize, static void get_smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,