From d4c49d966b4badad15f3f85c15bb8f802b9bfce6 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Wed, 3 May 2017 22:37:29 -0700 Subject: [PATCH] UPSTREAM: mainboard/google/poppy: Enable MODE_CHANGE event in SCI_MASK This is required to ensure that SCI is generated whenever a host event is set for MODE_CHANGE. Thus, when wake from MODE_CHANGE event occurs, eSPI SCI is generated which results in kernel handler reading host event from the EC and thus causes the wake pin to be de-asserted. BUG=b:37223093 TEST=Verified that wake from mode change event works fine in suspend mode and there is no interrupt storm for GPE SCI after resume. Change-Id: Ib82e9291b55c68a4508bd1ce3f5f5ad08fdb228e Signed-off-by: Patrick Georgi Original-Commit-Id: 730fc6c7d87647eaf0d89dc1b75642d350f04a34 Original-Change-Id: I1dd158ea0e302d5be9bcaa531cd1851082ba59fd Original-Signed-off-by: Furquan Shaikh Original-Reviewed-on: https://review.coreboot.org/19559 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Paul Menzel Original-Reviewed-by: Duncan Laurie Original-Reviewed-by: Aaron Durbin Original-Reviewed-by: Jenny Tc Reviewed-on: https://chromium-review.googlesource.com/497399 --- .../google/poppy/variants/baseboard/include/baseboard/ec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h index 8be83f3eda..5d6cf4c096 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h @@ -35,6 +35,7 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)) #define MAINBOARD_EC_SMI_EVENTS \