Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

UPSTREAM: nvramtool: Don't consider reserved regions to be "out of range"

Browse source 
Reserved regions showed different behavior for debug and regular builds.
Debug output was unfriendly, regular was wrong.
Print a proper error message and exit instead.

BUG=None
BRANCH=None
TEST=None

Change-Id: Ie00c6460d9973011dc682d07565b906a2f94003f
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1287076
Reviewed-on: https://review.coreboot.org/15968
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/366276
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
This commit is contained in:
Patrick Georgi 2016-07-29 21:01:19 +02:00 • committed by chrome-bot
parent 94419f2368
commit c9371ffe8f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
util/nvramtool/cli/nvramtool.c
View file

@ -761,7 +761,10 @@ static int list_cmos_entry(const cmos_entry_t * e, int show_name)
break;
case CMOS_OP_RESERVED:
BUG();
fprintf(stderr,
"%s: Cannot access reserved CMOS area (for %s).\n",
prog_name, e->name);
return 1;
case CMOS_AREA_OUT_OF_RANGE:
fprintf(stderr,