From b2677a7884dcd037ed1e7b513bd7e0d247d3267f Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Sat, 30 Jul 2016 13:10:44 +0200 Subject: [PATCH] UPSTREAM: sunw/ultra40m2: Fix handling non-existence of a device This probably never happens, but since we already test for the presence of the device, it makes no sense to try to configure it after its absense was determined. BUG=None BRANCH=None TEST=None Change-Id: Id5d321c712af70c374307643ced5c995431d324f Signed-off-by: Patrick Georgi Found-by: Coverity Scan #1347362 Reviewed-on: https://review.coreboot.org/15982 Tested-by: build bot (Jenkins) Reviewed-by: Jonathan A. Kollasch Reviewed-by: Paul Menzel Reviewed-by: Kysti Mlkki Reviewed-on: https://chromium-review.googlesource.com/366283 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Furquan Shaikh --- src/mainboard/sunw/ultra40m2/mainboard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mainboard/sunw/ultra40m2/mainboard.c b/src/mainboard/sunw/ultra40m2/mainboard.c index 3e2bbf004a..072e8a1b79 100644 --- a/src/mainboard/sunw/ultra40m2/mainboard.c +++ b/src/mainboard/sunw/ultra40m2/mainboard.c @@ -52,8 +52,10 @@ static void emc6d103_init(void) }; struct device * const dev = dev_find_slot_on_smbus(2, 0x2d); - if (dev == NULL) + if (dev == NULL) { printk(BIOS_WARNING, "EMC6D103 not found\n"); + return; + } printk(BIOS_SPEW, "%s EMC6D103 id: %x %x\n", __func__, smbus_read_byte(dev, 0x3e), smbus_read_byte(dev, 0x3f));