From b1b4b374c0266cf9c1bde37107b8f1fdf449fc50 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Tue, 13 Dec 2016 15:55:26 +0100 Subject: [PATCH] UPSTREAM: libpayload/drivers/video: Improve check in if condition Coverity considers this a copy&paste error, and maybe it is. In any case, it makes sense to check the variable that (if the condition is true) is changed, and the values are the same before that test, so the change is harmless. BUG=None BRANCH=None TEST=None Signed-off-by: Patrick Georgi Found-by: Coverity Scan #1347376 Reviewed-on: https://review.coreboot.org/17837 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Change-Id: I163c6a9f5baa05e715861dc19643b19a9c79c883 Reviewed-on: https://chromium-review.googlesource.com/420839 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Furquan Shaikh --- payloads/libpayload/drivers/video/graphics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index 943f8edcae..f1d916a18f 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -322,7 +322,7 @@ static int draw_bitmap_v3(const struct vector *top_left, for (d.y = 0; d.y < dim->height; d.y++, p.y += dir) { s0.y = d.y * scale->y.d / scale->y.n; s1.y = s0.y; - if (s0.y + 1 < dim_org->height) + if (s1.y + 1 < dim_org->height) s1.y++; ty.d = scale->y.n; ty.n = (d.y * scale->y.d) % scale->y.n;