From a8a0001bf307beb64d06917d3e073350a8f1f323 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= Date: Tue, 21 Feb 2017 13:10:05 +0100 Subject: [PATCH] UPSTREAM: commonlib/fsp.h: include sys/types.h for ssize_t This file reportedly didn't compile on SUSE Linux with gcc 4.3.4: [...] > HOSTCC cbfstool/fsp_relocate.o > In file included from coreboot/src/commonlib/fsp_relocate.c:18: > coreboot/src/commonlib/include/commonlib/fsp.h:26: error: > expected '=', ',', ';', 'asm' or '__attribute__' before > 'fsp_component_relocate' [...] According to POSIX-2008[1], sys/types.h defines ssize_t, so include it. This should not break coreboot code (as opposed to utils code), as we have a sys/types.h in src/include. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html BUG=none BRANCH=none TEST=none Change-Id: I61d49c1e118c7d16d2f4ec1b600796c7b996c6f3 Signed-off-by: Patrick Georgi Original-Commit-Id: b89b2c50c591bfe308094e35ae45e32df0cb35e2 Original-Change-Id: Id3694dc76c41d800ba09183e4b039b0719ac3d93 Original-Signed-off-by: Jonathan Neuschfer Original-Reviewed-on: https://review.coreboot.org/18417 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Nico Huber Original-Reviewed-by: Martin Roth Reviewed-on: https://chromium-review.googlesource.com/445833 --- src/commonlib/include/commonlib/fsp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/commonlib/include/commonlib/fsp.h b/src/commonlib/include/commonlib/fsp.h index 84e2c98a8b..a2a2faebe8 100644 --- a/src/commonlib/include/commonlib/fsp.h +++ b/src/commonlib/include/commonlib/fsp.h @@ -18,6 +18,7 @@ #include #include +#include /* * Relocate FSP held within buffer defined by size to new_addr. Returns < 0