From a34ee0224f1bf1121dcf8d6c4a04f0b8c8215d70 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 30 May 2017 14:25:32 -0400 Subject: [PATCH] UPSTREAM: purism/librem13v1: Set FADT revision to ACPI 3.0 The FADT revision was set to 5, but we do not implement the ACPI v5.0 specification, which prevents Windows from booting. Setting it to v3 (matching most other boards) fixes the issue and Windows now boots normally. Bug found by Matt DeVillier, fix tested by Youness Alaoui on Librem 13 v1 hardware. Please also see commits 00d250e2289de (intel/skylake: Switch FADT to ACPI version 3.0) [1] and 27e6042bb7d0b1 (intel/apollolake: Switch FADT to ACPI version 3.0) [2]. [1] https://review.coreboot.org/19453 [2] https://review.coreboot.org/19146 BUG=none BRANCH=none TEST=none Change-Id: I24a5d1d75ef0fca5b273d8d32d20812089850812 Signed-off-by: Patrick Georgi Original-Commit-Id: ab5b4c19c31d34ebb1ab697089f3626c50d2d801 Original-Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22 Original-Signed-off-by: Youness Alaoui Original-Signed-off-by: Matt DeVillier Original-Reviewed-on: https://review.coreboot.org/19985 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Werner Zeh Original-Reviewed-by: Paul Menzel Reviewed-on: https://chromium-review.googlesource.com/531685 Commit-Ready: Patrick Georgi Tested-by: Patrick Georgi Reviewed-by: Patrick Georgi --- src/mainboard/purism/librem13v1/fadt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/purism/librem13v1/fadt.c b/src/mainboard/purism/librem13v1/fadt.c index 980ff03a0f..9cbcd3f4f0 100644 --- a/src/mainboard/purism/librem13v1/fadt.c +++ b/src/mainboard/purism/librem13v1/fadt.c @@ -23,7 +23,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) memset(fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 5; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4);