Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

On 16.02.2008 07:41, ron minnich wrote:

Browse source 
> Alix1c won't boot with the zero decompress code.
> I think the code is using the wrong address on decompress.

Indeed, r601 broke all targets, you were just lucky that qemu didn't
explode as well.
It's the seemingly easy patches which break booting. With your hint, I
found the bug. Myles made a small, but important mistake with the memset
for the "zeroes" decompression.
The memset zeroed the archive instead of the destination. No wonder it
did explode.
This patch fixes it and also reverts the emergency commit r604 because
that one is no longer necessary.

Ron tested on the Alix1c, boots fine, ethernet and IDE working.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@605 f3766cd6-281f-0410-b1cd-43a5c92072e9
This commit is contained in:
Carl-Daniel Hailfinger 2008-02-16 19:18:32 +00:00
parent 24a06158ba
commit 9f07a52934
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/lar.c
View file

@ -172,7 +172,7 @@ int process_file(const struct mem_file *archive, void *where)
#endif
/* zeroes */
if (archive->compression == 3) {
memset(archive->start, 0, archive->reallen);
memset(where, 0, archive->reallen);
return 0;
}
printk(BIOS_INFO, "LAR: Compression algorithm #%i not supported!\n", archive->compression);

1
util/lar/stream.c
View file

@ -148,7 +148,6 @@ int output_elf_segments(struct lar *lar, char *name, char *filebuf,
continue;
}
thisalgo = zeroes;
thisalgo = algo;
if (verbose())
fprintf(stderr, "New section addr %#x size %#x\n",
(u32)shdr[i].sh_addr, (u32)shdr[i].sh_size);