From 958be72eb1e6b7fceb21234fe0ce8ce907229618 Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Wed, 26 Apr 2017 07:03:10 +0200 Subject: [PATCH] UPSTREAM: intel/skylake: Switch FADT to ACPI version 3.0 On Apollo Lake it was discovered that our current FADT implementation is valid for ACPI version 3.0 but misses fields for ACPI version 5.0. We run into booting issues with Windows 10 using version 5 in the FADT header. In commit 2b8552f49bc3a7d0290f96a84b573669de396011 (intel/apollolake: Switch FADT to ACPI version 3.0) we go back to version 3 for Apollo Lake. Skylake is now the last platform that uses version 5 in FADT header. BUG=none BRANCH=none TEST=none Change-Id: I70041118196641bb6cbf90cd8d16723bdca9be59 Signed-off-by: Patrick Georgi Original-Commit-Id: 00d250e2289de2e39ab6f69a61176405cdfa9ddb Original-Change-Id: I2d0367fae5321dee4ccac417b7f99466f8973577 Original-Signed-off-by: Werner Zeh Original-Reviewed-on: https://review.coreboot.org/19453 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/490081 Commit-Ready: Furquan Shaikh --- src/soc/intel/skylake/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index a75f5260a5..e8d0c1683a 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -226,8 +226,8 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC); config_t *config = dev->chip_info; - /* Use ACPI 5.0 revision */ - fadt->header.revision = ACPI_FADT_REV_ACPI_5_0; + /* Use ACPI 3.0 revision */ + fadt->header.revision = ACPI_FADT_REV_ACPI_3_0; fadt->sci_int = acpi_sci_irq(); fadt->smi_cmd = APM_CNT;