Here is a cleanup patch, removes 3 warnings from dtc build and some

commented-out code from stage0_i586.S. I am leaving the warnings about
gnu bintools in stage0_i586.S, just to make sure everyone knows why
some of the code is written the way it is, and nobody makes a mistake
in two years ...

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>



git-svn-id: svn://coreboot.org/repository/LinuxBIOSv3@244 f3766cd6-281f-0410-b1cd-43a5c92072e9
This commit is contained in:
Uwe Hermann 2007-03-11 19:54:30 +00:00
parent 9c67ea60b7
commit 92a68191ba
2 changed files with 4 additions and 17 deletions

View file

@ -31,12 +31,8 @@
#define CACHE_RAM_CODE_SEG 0x18
#define CACHE_RAM_DATA_SEG 0x20
# .section ".rom.text"
.code16
#.=0
.globl _stage0
# .section ".rom.text"
_stage0:
cli
@ -60,12 +56,6 @@ _stage0:
* the ld hackery and other things. So leave it as is with this comment.
*/
# movw %cs, %ax
# shlw $4, %ax
# movl $0xffffe000, %ebx
# movw $gdt16 + 0xe000, %bx
#subw %ax, %bx
#data32 lgdt %cs:(%bx)
data32 lgdt %cs:gdtptr
movl %cr0, %eax
@ -504,9 +494,6 @@ var_mtrr_msr:
SEGMENT_SIZE = 0x10000
RVECTOR = 0x00010
#.=0x1ff0
#.=0xfffffff0
#.=_stage0 + 0x1ff0
# Due to YET ANOTHER BUG in GNU bintools, you can NOT have a code16 here.
# I think we should leave it this way forever, as the bugs come and
# go -- and come again.
@ -515,7 +502,7 @@ RVECTOR = 0x00010
.section ".reset", "ax"
.globl _resetjump
_resetjump:
/* GNU bintools win again. This jumps to stage0 - 2. Sigh. */
/* GNU bintools bugs again. This jumps to stage0 - 2. Sigh. */
# jmp _stage0
.byte 0xe9
.int _stage0 - ( . + 2 )

View file

@ -181,7 +181,7 @@ static void asm_emit_cell(void *e, cell_t val)
static void asm_emit_string(void *e, char *str, int len)
{
FILE *f = e;
char c;
char c = 0;
if (len != 0) {
/* XXX: ewww */
@ -283,7 +283,7 @@ static void C_emit_cell(void *e, cell_t val)
static void C_emit_string(void *e, char *str, int len)
{
FILE *f = e;
char c;
char c = 0;
if (len != 0) {
/* XXX: ewww */
@ -404,7 +404,7 @@ static void linuxbios_emit_cell(void *e, cell_t val)
static void linuxbios_emit_string(void *e, char *str, int len)
{
FILE *f = e;
char c;
char c = 0;
if (len != 0) {
/* XXX: ewww */