From 7cd937c15c994abdfa11dafb905254ddeb2c3073 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 15 Dec 2016 15:14:59 +0100 Subject: [PATCH] UPSTREAM: util/romcc: Move access after NULL-check Change-Id: I7f9c38fd6e75b32fe1ed8a60c7054f4dd1fcd5c0 Original-Signed-off-by: Patrick Georgi Original-Found-by: Coverity Scan #1129104 Original-Reviewed-on: https://review.coreboot.org/17884 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Martin Roth Signed-off-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/421218 Reviewed-by: Patrick Georgi --- util/romcc/romcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 9a9016741f..655e6f5ed1 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -6287,10 +6287,10 @@ static size_t field_reg_offset(struct compile_state *state, internal_error(state, 0, "field_reg_offset only works on structures and unions"); } - size += reg_needed_padding(state, member, size); if (!member || (member->field_ident != field)) { error(state, 0, "member %s not present", field->name); } + size += reg_needed_padding(state, member, size); return size; }