From 5feb9b51a0e691400d3a881b386f74b5854c3803 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Wed, 20 Jul 2016 03:23:06 +0300 Subject: [PATCH] UPSTREAM: AMD k8 fam10: Fix CAR GLOBALS late in romstage Zero-filling memory below 1 MiB resets car_migrated variable so any CAR GLOBALs are not addressed correctly for the remaining time in romstage. Also there is no actual need to do this as ramstage loader handles BSS. This fixes regression with commit 70cd54310 that broke fam10 boards with romstage spinlocks enabled. BUG=None BRANCH=None TEST=None Signed-off-by: Kysti Mlkki Reviewed-on: https://review.coreboot.org/15754 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Tested-by: Raptor Engineering Automated Test Stand Change-Id: I7418821997a980ae5b818bd57e8a1b6507a543af Reviewed-on: https://chromium-review.googlesource.com/362342 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Furquan Shaikh --- src/cpu/amd/car/post_cache_as_ram.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/cpu/amd/car/post_cache_as_ram.c b/src/cpu/amd/car/post_cache_as_ram.c index 9cf3c6e78f..ad5a5c7dcf 100644 --- a/src/cpu/amd/car/post_cache_as_ram.c +++ b/src/cpu/amd/car/post_cache_as_ram.c @@ -89,9 +89,6 @@ static void prepare_ramstage_region(int s3resume) if (resume_backup_memory) memcpy_(resume_backup_memory, (void *) CONFIG_RAMBASE, HIGH_MEMORY_SAVE - backup_top); - memset_((void*) CONFIG_RAMBASE, 0, HIGH_MEMORY_SAVE - backup_top); - } else { - memset_((void*)0, 0, CONFIG_RAMTOP - backup_top); } print_car_debug(" Done\n");